This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Add missing const * updates in StandardAttributes
ClosedPublic

Authored by tpopp on Nov 19 2020, 1:50 PM.

Details

Summary

This add missing updates to the header file that caused linking issues.
Original change at https://reviews.llvm.org/D91740

Diff Detail

Event Timeline

tpopp created this revision.Nov 19 2020, 1:50 PM
tpopp requested review of this revision.Nov 19 2020, 1:50 PM
GeorgeLyon accepted this revision.Nov 19 2020, 1:54 PM

Whoops, thank you for catching this... these must have disappeared when I was fixing MLIR_CAPI_EXPORTED-related merge conflicts

This revision is now accepted and ready to land.Nov 19 2020, 1:54 PM
This revision was landed with ongoing or failed builds.Nov 19 2020, 1:56 PM
This revision was automatically updated to reflect the committed changes.
tpopp added a comment.Nov 19 2020, 1:57 PM

No problem :) It's just unfortunate there weren't any tests using this to catch this.