Page MenuHomePhabricator

[libc] Combine all math differential fuzzers into one target.
ClosedPublic

Authored by sivachandra on Nov 19 2020, 1:12 PM.

Details

Summary

Also added diffing of a few more math functions. Combining the diff check
for all of these functions helps us meet the OSS fuzz bar of a minimum of
100 program edges.

Diff Detail

Event Timeline

sivachandra created this revision.Nov 19 2020, 1:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 19 2020, 1:12 PM
sivachandra requested review of this revision.Nov 19 2020, 1:12 PM

See the discussion here for information on oss-fuzz's minimum program edge requirement: https://github.com/google/oss-fuzz/pull/3418

sivachandra retitled this revision from [lib] Combine all math differential fuzzers into one target. to [libc] Combine all math differential fuzzers into one target..Nov 19 2020, 1:15 PM
lntue added inline comments.Nov 19 2020, 1:34 PM
libc/fuzzing/math/SingleInputSingleOutputDiff.h
38

Why these checks are not isnan(r1) != isnan(r2)
and isinf(r1) != isinf(r2) ?

libc/fuzzing/math/TwoInputSingleOutputDiff.h
40

same comment as SingleInputSingleOutput

  • Add more functions diffs.
  • Address comments.
libc/fuzzing/math/SingleInputSingleOutputDiff.h
38

Doing this in a different way now.

libc/fuzzing/math/TwoInputSingleOutputDiff.h
40

Ditto.

lntue accepted this revision.Nov 20 2020, 6:24 AM
This revision is now accepted and ready to land.Nov 20 2020, 6:24 AM
This revision was landed with ongoing or failed builds.Nov 20 2020, 7:46 AM
This revision was automatically updated to reflect the committed changes.