[lldb] [test] Un-XFAIL tests on freebsd/i386

[mgorny]

Summary

Restrict i386-specific XFAIL on a few tests to non-FreeBSD systems,
as they pass on FreeBSD.

[emaste]

lldb/test/API/functionalities/exec/TestExec.py

19–21

Interesting, so FreeBSD is now the only OS where this test passes on i386?

Of course rdar://28656532 is opaque, would be nice if Apple folks can provide some insight on this.

[labath]

These seems to pass on linux as well (and possibly others too), but I guess nobody runs i386 tests these days...

[mgorny]

lldb/test/API/functionalities/exec/TestExec.py

19–21

I suspect others might pass too and this is a Darwin-specific issue but I don't have 32-bit NetBSD install handy at the moment, and LLDB doesn't seem to work at all on Arch Linux 32 for some obscure reason.

[labath]

lldb/test/API/functionalities/exec/TestExec.py

19–21

I was actually running the test on a 64-bit multilib system. It's possible that a pure 32-bit system behaves differently.

[labath]

lldb/test/API/functionalities/exec/TestExec.py

19–21

(or just a 32-bit build of lldb)

[emaste]

lldb/test/API/functionalities/exec/TestExec.py

19–21

Ah, fair point. I'm not all that interested in FreeBSD/i386 tbh, it just seemed surprising.

lldb/test/API/functionalities/exec/TestExec.py

 
 
 class ExecTestCase(TestBase):
 
     NO_DEBUG_INFO_TESTCASE = True
 
     mydir = TestBase.compute_mydir(__file__)
 
-    @expectedFailureAll(archs=['i386'], bugnumber="rdar://28656532")
+    @expectedFailureAll(archs=['i386'],
+                        oslist=no_match(["freebsd"]),
+                        bugnumber="rdar://28656532")
     @expectedFailureAll(oslist=["ios", "tvos", "watchos", "bridgeos"], bugnumber="rdar://problem/34559552") # this exec test has problems on ios systems
     @expectedFailureNetBSD
     @skipIfAsan # rdar://problem/43756823
     @skipIfWindows
     def test_hitting_exec (self):
         self.do_test(False)
 
-    @expectedFailureAll(archs=['i386'], bugnumber="rdar://28656532")
+    @expectedFailureAll(archs=['i386'],
+                        oslist=no_match(["freebsd"]),
+                        bugnumber="rdar://28656532")
     @expectedFailureAll(oslist=["ios", "tvos", "watchos", "bridgeos"], bugnumber="rdar://problem/34559552") # this exec test has problems on ios systems
     @expectedFailureNetBSD
     @skipIfAsan # rdar://problem/43756823
     @skipIfWindows
     def test_skipping_exec (self):
         self.do_test(True)
 
     def do_test(self, skip_exec):

lldb/test/API/functionalities/step-avoids-no-debug/TestStepNoDebug.py

class StepAvoidsNoDebugTestCase(TestBase):
     @decorators.expectedFailureAll(
         compiler="gcc", bugnumber="llvm.org/pr28549")
     @decorators.expectedFailureAll(
         compiler="clang",
         compiler_version=[
             ">=",
             "3.9"],
         archs=["i386"],
+        oslist=no_match(["freebsd"]),
         bugnumber="llvm.org/pr28549")
     def test_step_over_with_python(self):
         """Test stepping over using avoid-no-debug with dwarf."""
         self.build()
         self.get_to_starting_point()
         self.do_step_over_past_nodebug()
 
     @add_test_categories(['pyapi'])
     @decorators.expectedFailureAll(
         compiler="gcc", bugnumber="llvm.org/pr28549")
     @decorators.expectedFailureAll(
         compiler="clang",
         compiler_version=[
             ">=",
             "3.9"],
         archs=["i386"],
+        oslist=no_match(["freebsd"]),
         bugnumber="llvm.org/pr28549")
     @expectedFailureAll(archs=["arm64"], bugnumber="<rdar://problem/34026777>")  # lldb doesn't step past last source line in function on arm64
     @expectedFailureAll(archs=["aarch64"], oslist=["linux"],
                         bugnumber="llvm.org/pr44057")
     def test_step_in_with_python(self):
         """Test stepping in using avoid-no-debug with dwarf."""
         self.build()
         self.get_to_starting_point()