This is an archive of the discontinued LLVM Phabricator instance.

[OPENMP]Fix PR48076: mapping of data member pointer.
ClosedPublic

Authored by ABataev on Nov 16 2020, 10:22 AM.

Details

Summary

If the data member pointer is mapped, the compiler tries to optimize the
mapping of such data by discarding explicit mapping flags and trying to
emit combined data instead. In some cases, this optimization is not
quite correctly implemented and it leads to a program crash at the
runtime. Instead, if the data member is mapped, just emit it as is and
do not emit combined mapping flags for it.

Diff Detail

Event Timeline

ABataev created this revision.Nov 16 2020, 10:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2020, 10:22 AM
ABataev requested review of this revision.Nov 16 2020, 10:22 AM
ABataev updated this revision to Diff 305553.

Rename

ABataev retitled this revision from [OPENMP]Fix mapping of data member pointer. to [OPENMP]Fix PR48076: mapping of data member pointer..Nov 16 2020, 10:24 AM
jhuber6 accepted this revision.Nov 16 2020, 11:17 AM

LGTM, fixed the problem on my machine and passes the unit tests.

This revision is now accepted and ready to land.Nov 16 2020, 11:17 AM
This revision was landed with ongoing or failed builds.Nov 17 2020, 7:27 AM
This revision was automatically updated to reflect the committed changes.