Fix temporary file name on Windows

[yaxunl]

Summary

Bound arch may contain ':', which is invalid in Windows file names.

This patch fixes that.

[yaxunl]

add end of line to test

[tra]

LGTM overall, nit about the character choice.

clang/lib/Driver/Driver.cpp

4702

Windows cmd shell uses % to reference environment variables. The character is valid for a path, but that would be similar to using $ in the path name on Linux -- doable, but rather inconvenient to deal with.

Perhaps a less special character would be a better choice. _, ., or @ ?

[yaxunl]

clang/lib/Driver/Driver.cpp

4702

I would choose '@' if '%' is not favored. In some cases we may want to recover the bound arch from the temporary file name. '.' and '_' makes it difficult to recover.

clang/lib/Driver/Driver.cpp

static bool HasPreprocessOutput(const Action &JA) {
   if (isa<OffloadBundlingJobAction>(JA) &&
       HasPreprocessOutput(*(JA.getInputs()[0])))
     return true;
   return false;
 }
 
 const char *Driver::GetNamedOutputPath(Compilation &C, const JobAction &JA,
                                        const char *BaseInput,
-                                       StringRef BoundArch, bool AtTopLevel,
+                                       StringRef OrigBoundArch, bool AtTopLevel,
                                        bool MultipleArchs,
                                        StringRef OffloadingPrefix) const {
+  std::string BoundArch = OrigBoundArch.str();
+#if defined(_WIN32)
+  // BoundArch may contains ':', which is invalid in file names on Windows,
+  // therefore replace it with '%'.
+  std::replace(BoundArch.begin(), BoundArch.end(), ':', '@');
+#endif
+
   llvm::PrettyStackTraceString CrashInfo("Computing output path");
   // Output to a user requested destination?
   if (AtTopLevel && !isa<DsymutilJobAction>(JA) && !isa<VerifyJobAction>(JA)) {
     if (Arg *FinalOutput = C.getArgs().getLastArg(options::OPT_o))
       return C.addResultFile(FinalOutput->getValue(), &JA);
   }
 
   // For /P, preprocess to file named after BaseInput.

clang/test/Driver/hip-windows-filename.hip

+// REQUIRES: system-windows, clang-driver, amdgpu-registered-target
+
+// RUN: %clang -### -target x86_64-pc-windows-msvc \
+// RUN:   -x hip \
+// RUN:   --offload-arch=gfx908:xnack+ \
+// RUN:   -nogpuinc -nogpulib -save-temps \
+// RUN:   %s 2>&1 | FileCheck %s
+
+// CHECK: "-o" "hip-windows-filename-hip-amdgcn-amd-amdhsa-gfx908@xnack+.cui"
+// CHECK-NOT: "-o" "hip-windows-filename-hip-amdgcn-amd-amdhsa-gfx908:xnack+.cui"