Page MenuHomePhabricator

[ThreadPlan] Add a test for `thread step-in -r`, NFC
ClosedPublic

Authored by vsk on Nov 10 2020, 4:10 PM.

Diff Detail

Unit TestsFailed

TimeTest
190 mslinux > Clang-Unit.ASTMatchers/_/ASTMatchersTests::Traversal.traverseUnlessSpelledInSource
Note: Google Test filter = Traversal.traverseUnlessSpelledInSource [==========] Running 1 test from 1 test case. [----------] Global test environment set-up.
40 mslinux > Clang-Unit.Tooling/_/ToolingTests::StencilTest.AccessOpExplicitThis
Note: Google Test filter = StencilTest.AccessOpExplicitThis [==========] Running 1 test from 1 test case. [----------] Global test environment set-up.
40 mslinux > Clang-Unit.Tooling/_/ToolingTests::StencilTest.AccessOpImplicitThis
Note: Google Test filter = StencilTest.AccessOpImplicitThis [==========] Running 1 test from 1 test case. [----------] Global test environment set-up.
1,580 mswindows > Clang-Unit.ASTMatchers/_/ASTMatchersTests_exe::Traversal.traverseUnlessSpelledInSource
Note: Google Test filter = Traversal.traverseUnlessSpelledInSource [==========] Running 1 test from 1 test case.
70 mswindows > Clang-Unit.Tooling/_/ToolingTests_exe::StencilTest.AccessOpExplicitThis
Note: Google Test filter = StencilTest.AccessOpExplicitThis [==========] Running 1 test from 1 test case.
View Full Test Results (6 Failed)

Event Timeline

vsk created this revision.Nov 10 2020, 4:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2020, 4:10 PM
vsk requested review of this revision.Nov 10 2020, 4:10 PM

It's easier to read these tests if you use "lldbutil.run_to_source_breakpoint" to remove all that boilerplate.

Other than that LGTM. Thanks for adding the test!

lldb/test/API/lang/c/stepping/TestThreadStepInAvoidRegexp.py
28–46

All this can be collapsed into

lldbutil.run_to_source_breakpoint("// frame select 2, thread step-out...", lldb.SBFileSpec("main.c"))

and it will do all the right checks for you.

vsk updated this revision to Diff 304355.Nov 10 2020, 4:27 PM

Simplify, using run_to_source_breakpoint.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 10 2020, 4:38 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.