[ThreadPlan] Add a test for `thread step-in -r`, NFC

[vsk]

Summary

Adds test coverage for ThreadPlanStepInRange::SetAvoidRegexp.

See:
http://lab.llvm.org:8080/coverage/coverage-reports/coverage/Users/buildslave/jenkins/workspace/coverage/llvm-project/lldb/source/Target/ThreadPlanStepInRange.cpp.html#L309

[jingham]

It's easier to read these tests if you use "lldbutil.run_to_source_breakpoint" to remove all that boilerplate.

Other than that LGTM. Thanks for adding the test!

lldb/test/API/lang/c/stepping/TestThreadStepInAvoidRegexp.py

28–46

All this can be collapsed into

lldbutil.run_to_source_breakpoint("// frame select 2, thread step-out...", lldb.SBFileSpec("main.c"))

and it will do all the right checks for you.

[vsk]

Simplify, using run_to_source_breakpoint.

[stella.stamenova]

This test is failing on the Windows bot:

http://lab.llvm.org:8011/#/builders/83/builds/678

lldb/packages/Python/lldbsuite/test/lldbtest.py

 BREAKPOINT_HIT_THRICE = "Breakpoint resolved with hit count = 3"
 
 MISSING_EXPECTED_REGISTERS = "At least one expected register is unavailable."
 
 OBJECT_PRINTED_CORRECTLY = "Object printed correctly"
 
 SOURCE_DISPLAYED_CORRECTLY = "Source code displayed correctly"
 
+STEP_IN_SUCCEEDED = "Thread step-in succeeded"
+
 STEP_OUT_SUCCEEDED = "Thread step-out succeeded"
 
 STOPPED_DUE_TO_EXC_BAD_ACCESS = "Process should be stopped due to bad access exception"
 
 STOPPED_DUE_TO_ASSERT = "Process should be stopped due to an assertion"
 
 STOPPED_DUE_TO_BREAKPOINT = "Process should be stopped due to breakpoint"
 

lldb/test/API/lang/c/stepping/TestThreadStepInAvoidRegexp.py

+"""
+Test thread step-in [ -r | --step-over-regexp ].
+"""
+
+
+
+import lldb
+from lldbsuite.test.lldbtest import *
+import lldbsuite.test.lldbutil as lldbutil
+
+
+class ThreadStepInAvoidRegexTestCase(TestBase):
+
+    mydir = TestBase.compute_mydir(__file__)
+
+    def setUp(self):
+        TestBase.setUp(self)
+        self.line2 = line_number('main.c', '// assignment to B2')
+
+    def test_step_out_avoid_regexp(self):
+        """Exercise thread step-in -r"""
+        self.build()
+        lldbutil.run_to_source_breakpoint(self,
+                'frame select 2, thread step-out while stopped',
+                lldb.SBFileSpec('main.c'))
+
+        # Now step in, skipping the frames for 'b' and 'a'.
+        self.runCmd("thread step-in -r 'a'")
+
+        # We should be at the assignment to B2.
+        self.expect("thread backtrace", STEP_IN_SUCCEEDED,
+                    substrs=["stop reason = step in"],
+                    patterns=["frame #0.*main.c:%d" % self.line2])

lldb/test/API/lang/c/stepping/main.c

 {
     return first + second + third;  // Step in targeting complex should stop here
 }
 
 int main (int argc, char const *argv[])
 {
     int A1 = a(1); // frame select 2, thread step-out while stopped at "c(1)"
 
-    int B2 = b(2);
+    int B2 = b(2); // assignment to B2
 
     int A3 = a(3); // frame select 1, thread step-out while stopped at "c(3)"
 
     int A4 = complex (a(1), b(2), c(3)); // Stop here to try step in targeting b.
 
     int A5 = complex (a(2), b(3), c(4)); // Stop here to try step in targeting complex.
 
     int A6 = complex (a(4), b(5), c(6)); // Stop here to step targeting b and hitting breakpoint.
 
     int A7 = complex (a(5), b(6), c(7)); // Stop here to make sure bogus target steps over.
 
     return A1 + B2 + A3 + A4 + A5 + A6 + A7 + *print_string;
 }