This is an archive of the discontinued LLVM Phabricator instance.

Differential D91091

[update_test_checks] Allow opt to have .exe file extension
ClosedPublic

Authored by aeubanks on Nov 9 2020, 10:36 AM.

Details

Reviewers
rnk
hans
Commits
rGd1171bca963b: [update_test_checks] Allow opt to have .exe file extension

Diff Detail

Unit TestsFailed

TimeTest
380 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp

Event Timeline

aeubanks created this revision.Nov 9 2020, 10:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 9 2020, 10:36 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aeubanks requested review of this revision.Nov 9 2020, 10:36 AM
Harbormaster completed remote builds in B78156: Diff 303929.Nov 9 2020, 11:24 AM
rnk accepted this revision.Nov 9 2020, 2:40 PM
This revision is now accepted and ready to land.Nov 9 2020, 2:40 PM
This revision was landed with ongoing or failed builds.Nov 9 2020, 3:50 PM
Closed by commit rGd1171bca963b: [update_test_checks] Allow opt to have .exe file extension (authored by aeubanks). · Explain Why
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rGd1171bca963b: [update_test_checks] Allow opt to have .exe file extension.

Revision Contents

PathSize
llvm/
utils/
2 lines

Diff 303929

llvm/utils/update_test_checks.py

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Lines parser.add_argument('--scrub-attributes', action='store_true',
help='Remove attribute annotations (#0) from the end of check line') help='Remove attribute annotations (#0) from the end of check line')
parser.add_argument('--check-attributes', action='store_true', parser.add_argument('--check-attributes', action='store_true',
help='Check "Function Attributes" for functions') help='Check "Function Attributes" for functions')
parser.add_argument('tests', nargs='+') parser.add_argument('tests', nargs='+')
initial_args = common.parse_commandline_args(parser) initial_args = common.parse_commandline_args(parser)
script_name = os.path.basename(__file__) script_name = os.path.basename(__file__)
opt_basename = os.path.basename(initial_args.opt_binary) opt_basename = os.path.basename(initial_args.opt_binary)
if not re.match(r'^opt(-\d+)?$', opt_basename): if not re.match(r'^opt(-\d+)?(\.exe)?$', opt_basename):
common.error('Unexpected opt name: ' + opt_basename) common.error('Unexpected opt name: ' + opt_basename)
sys.exit(1) sys.exit(1)
opt_basename = 'opt' opt_basename = 'opt'
for ti in common.itertests(initial_args.tests, parser, for ti in common.itertests(initial_args.tests, parser,
script_name='utils/' + script_name): script_name='utils/' + script_name):
# If requested we scrub trailing attribute annotations, e.g., '#0', together with whitespaces # If requested we scrub trailing attribute annotations, e.g., '#0', together with whitespaces
if ti.args.scrub_attributes: if ti.args.scrub_attributes:
▲ Show 20 Lines • Show All 131 Lines • Show Last 20 Lines