This is an archive of the discontinued LLVM Phabricator instance.

Differential D90921

[Clang][AArch64] Remove unused prefix in constrained rounding test
ClosedPublic

Authored by DavidSpickett on Nov 6 2020, 3:01 AM.

Download Raw Diff

Details

Reviewers

kpn

Commits

rGaecd52b97bb4: [Clang][AArch64] Remove unused prefix in constrained rounding test

Summary

This test was added in 7f38812d5b7e0fd5145e44d5ae831a67d782dca6
and all the other tests make use of the COMMONIR check. So I think
this was left in by mistake for this particular test.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

DavidSpickett created this revision.Nov 6 2020, 3:01 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 6 2020, 3:01 AM

Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. · View Herald Transcript

DavidSpickett requested review of this revision.Nov 6 2020, 3:01 AM

In case this looks like a spammy change, this is for http://llvm.1065342.n5.nabble.com/llvm-dev-RFC-FileCheck-dis-allowing-unused-prefixes-td142255.html

AFAICT there is no common IR to check for in this test, unlike the others.

Harbormaster completed remote builds in B77852: Diff 303391.Nov 6 2020, 3:13 AM

LGTM

This revision is now accepted and ready to land.Nov 6 2020, 6:05 AM

This revision was landed with ongoing or failed builds.Nov 6 2020, 6:14 AM

Closed by commit rGaecd52b97bb4: [Clang][AArch64] Remove unused prefix in constrained rounding test (authored by DavidSpickett). · Explain Why

This revision was automatically updated to reflect the committed changes.

DavidSpickett added a commit: rGaecd52b97bb4: [Clang][AArch64] Remove unused prefix in constrained rounding test.

Revision Contents

Path

Size

clang/

test/

CodeGen/

arm64-vrnd-constrained.c

4 lines

Diff 303425

clang/test/CodeGen/arm64-vrnd-constrained.c

	// RUN: %clang_cc1 -triple arm64-apple-ios7 -target-feature +neon -ffreestanding -flax-vector-conversions=none -emit-llvm -o - %s \			// RUN: %clang_cc1 -triple arm64-apple-ios7 -target-feature +neon -ffreestanding -flax-vector-conversions=none -emit-llvm -o - %s \
	// RUN: \| FileCheck --check-prefix=COMMON --check-prefix=COMMONIR --check-prefix=UNCONSTRAINED %s			// RUN: \| FileCheck --check-prefix=COMMON --check-prefix=UNCONSTRAINED %s
	// RUN: %clang_cc1 -triple arm64-apple-ios7 -target-feature +neon -ffreestanding -flax-vector-conversions=none -fexperimental-strict-floating-point -ffp-exception-behavior=strict -emit-llvm -o - %s \			// RUN: %clang_cc1 -triple arm64-apple-ios7 -target-feature +neon -ffreestanding -flax-vector-conversions=none -fexperimental-strict-floating-point -ffp-exception-behavior=strict -emit-llvm -o - %s \
	// RUN: \| FileCheck --check-prefix=COMMON --check-prefix=COMMONIR --check-prefix=CONSTRAINED %s			// RUN: \| FileCheck --check-prefix=COMMON --check-prefix=CONSTRAINED %s
	// RUN: %clang_cc1 -triple arm64-apple-ios7 -target-feature +neon -ffreestanding -flax-vector-conversions=none -emit-llvm -o - %s \| llc -o=- - \			// RUN: %clang_cc1 -triple arm64-apple-ios7 -target-feature +neon -ffreestanding -flax-vector-conversions=none -emit-llvm -o - %s \| llc -o=- - \
	// RUN: \| FileCheck --check-prefix=COMMON --check-prefix=CHECK-ASM %s			// RUN: \| FileCheck --check-prefix=COMMON --check-prefix=CHECK-ASM %s
	// RUN: %clang_cc1 -triple arm64-apple-ios7 -target-feature +neon -ffreestanding -flax-vector-conversions=none -fexperimental-strict-floating-point -ffp-exception-behavior=strict -emit-llvm -o - %s \| llc -o=- - \			// RUN: %clang_cc1 -triple arm64-apple-ios7 -target-feature +neon -ffreestanding -flax-vector-conversions=none -fexperimental-strict-floating-point -ffp-exception-behavior=strict -emit-llvm -o - %s \| llc -o=- - \
	// RUN: \| FileCheck --check-prefix=COMMON --check-prefix=CHECK-ASM %s			// RUN: \| FileCheck --check-prefix=COMMON --check-prefix=CHECK-ASM %s

	// REQUIRES: aarch64-registered-target			// REQUIRES: aarch64-registered-target

	#include <arm_neon.h>			#include <arm_neon.h>
	Show All 31 Lines