This is an archive of the discontinued LLVM Phabricator instance.

[VE][NFC] Refactor to support more than one calling conv
ClosedPublic

Authored by simoll on Nov 6 2020, 1:22 AM.

Details

Summary

Prepare for supporting different calling conventions by factoring out things into CC-dependent selection functions (getParamCC, getReturnCC).

Diff Detail

Event Timeline

simoll created this revision.Nov 6 2020, 1:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 6 2020, 1:22 AM
simoll requested review of this revision.Nov 6 2020, 1:22 AM
kaz7 added a comment.Nov 6 2020, 1:27 AM

Thank you for separating this!

llvm/lib/Target/VE/VEISelLowering.cpp
536

It's better to be getParamCC(CLI.CallConv, true). All calls using getParamCC should be written in the similar manner.

simoll updated this revision to Diff 303381.Nov 6 2020, 2:16 AM
simoll marked an inline comment as done.

Made getParamCC calls all the same.

kaz7 accepted this revision.Nov 6 2020, 2:58 AM

Thanks. LGTM.

This revision is now accepted and ready to land.Nov 6 2020, 2:58 AM
This revision was landed with ongoing or failed builds.Nov 6 2020, 5:25 AM
This revision was automatically updated to reflect the committed changes.