This is an archive of the discontinued LLVM Phabricator instance.

Frontend: Remove redundant call to CompilerInstance::setFileManager, NFC
ClosedPublic

Authored by dexonsmith on Nov 5 2020, 2:28 PM.

Details

Summary

ASTUnit::Parse sets up the FileManager earlier in the same function,
ensuring ASTUnit::getFileManager() matches Clang->getFileManager().
Remove the later call to setFileManager(getFileManager()) since it
does nothing.

Diff Detail

Event Timeline

dexonsmith created this revision.Nov 5 2020, 2:28 PM
dexonsmith requested review of this revision.Nov 5 2020, 2:28 PM
dexonsmith added inline comments.
clang/lib/Frontend/ASTUnit.cpp
1135–1141

Here's where the FileManager was already set up.

This revision is now accepted and ready to land.Dec 1 2020, 8:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2020, 4:11 PM