Page MenuHomePhabricator

[libc][NFC] Make test macros callable from helper methods of test classes.
ClosedPublic

Authored by sivachandra on Nov 4 2020, 4:09 PM.

Details

Summary

This is acheived by making the RunContext a state variable of the test
classes.

Diff Detail

Event Timeline

sivachandra created this revision.Nov 4 2020, 4:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 4 2020, 4:09 PM
sivachandra requested review of this revision.Nov 4 2020, 4:09 PM
sivachandra added a comment.EditedNov 4 2020, 4:15 PM

This helps us setup math tests for float, double and long double flavors of a functions without a lot of duplicated logic. See the tests of remquo, remquof and remquol for examples. In contrast, I used this change to set up tests for ilogb, ilogbf and ilogbl without any duplicated logic: https://reviews.llvm.org/D90806.

lntue accepted this revision.Nov 4 2020, 6:13 PM
This revision is now accepted and ready to land.Nov 4 2020, 6:13 PM
This revision was landed with ongoing or failed builds.Nov 5 2020, 4:14 PM
This revision was automatically updated to reflect the committed changes.