This is an archive of the discontinued LLVM Phabricator instance.

Frontend: Sink named pipe logic from CompilerInstance down to FileManager
ClosedPublic

Authored by dexonsmith on Nov 3 2020, 7:26 PM.

Details

Summary

Remove compilicated logic from CompilerInstance::InitializeSourceManager
to deal with named pipes, updating FileManager::getBufferForFile to
handle it in a more straightforward way. The existing test at
clang/test/Misc/dev-fd-fs.c covers the new behaviour.

Diff Detail

Event Timeline

dexonsmith created this revision.Nov 3 2020, 7:26 PM
dexonsmith requested review of this revision.Nov 3 2020, 7:26 PM
This revision is now accepted and ready to land.Dec 1 2020, 8:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2020, 5:14 PM

Hmm, I had to revert this in b34632201987eed369bb7ef4646f341b901c95b8 due to a bot failure; I'll need to look into it.

Hmm, I had to revert this in b34632201987eed369bb7ef4646f341b901c95b8 due to a bot failure; I'll need to look into it.

Posted a new version here: https://reviews.llvm.org/D92531