This is an archive of the discontinued LLVM Phabricator instance.

Differential D90718

Set the flag so that compler-rt-CMake will set COMPILER_RT_HAS_LLD=true (See compiler-rt/CMakeLists.txt, line ~592)
AbandonedPublic

Authored by vitalybuka on Nov 3 2020, 2:32 PM.

Details

Reviewers
gkistanova
oontvoo
Summary

Without this, COMPILER_RT_HAS_LLD is always false, resulting in all tests being marked as "unsupported".

Diff Detail

Event Timeline

oontvoo created this revision.Nov 3 2020, 2:32 PM
Herald added a reviewer: gkistanova. · View Herald TranscriptNov 3 2020, 2:32 PM
Herald added a subscriber: dberris. · View Herald Transcript
oontvoo requested review of this revision.Nov 3 2020, 2:32 PM
Harbormaster completed remote builds in B77470: Diff 302690.Nov 3 2020, 2:32 PM
oontvoo edited the summary of this revision. (Show Details)Nov 3 2020, 2:41 PM
vitalybuka added inline comments.Nov 3 2020, 3:56 PM
zorg/buildbot/builders/sanitizers/buildbot_android_functions.sh
113

we can't do that, here we cross compile stuff for android, we can't build lld here
we should have lld from build_stage2_android

oontvoo added a child revision: D90720: Use LLD for Android compiler-rt.Nov 3 2020, 5:43 PM
vitalybuka commandeered this revision.Nov 4 2020, 1:31 AM
vitalybuka abandoned this revision.
vitalybuka edited reviewers, added: oontvoo; removed: vitalybuka.

Revision Contents

PathSize
zorg/
buildbot/
builders/
sanitizers/
1 line

Diff 302690

zorg/buildbot/builders/sanitizers/buildbot_android_functions.sh

Show First 20 Lines • Show All 104 Lines • ▼ Show 20 Lines (cd compiler_rt_build_android_$_arch && cmake \
-DCMAKE_ASM_FLAGS="$ANDROID_FLAGS" \ -DCMAKE_ASM_FLAGS="$ANDROID_FLAGS" \
-DCMAKE_C_FLAGS="$ANDROID_FLAGS" \ -DCMAKE_C_FLAGS="$ANDROID_FLAGS" \
-DCMAKE_CXX_FLAGS="$ANDROID_CXX_FLAGS" \ -DCMAKE_CXX_FLAGS="$ANDROID_CXX_FLAGS" \
-DANDROID_NDK_VERSION=$ANDROID_NDK_VERSION \ -DANDROID_NDK_VERSION=$ANDROID_NDK_VERSION \
-DSANITIZER_CXX_ABI="libcxxabi" \ -DSANITIZER_CXX_ABI="libcxxabi" \
-DANDROID=1 \ -DANDROID=1 \
-DCOMPILER_RT_TEST_COMPILER_CFLAGS="$ANDROID_FLAGS" \ -DCOMPILER_RT_TEST_COMPILER_CFLAGS="$ANDROID_FLAGS" \
-DCOMPILER_RT_TEST_TARGET_TRIPLE=$_triple \ -DCOMPILER_RT_TEST_TARGET_TRIPLE=$_triple \
-DLLVM_TOOL_LLD_BUILD=ON \
vitalybukaAuthorUnsubmitted
Not Done
ReplyInline Actions

we can't do that, here we cross compile stuff for android, we can't build lld here
we should have lld from build_stage2_android

vitalybuka: we can't do that, here we cross compile stuff for android, we can't build lld here we should…
-DCOMPILER_RT_OUTPUT_DIR="$ANDROID_LIBRARY_OUTPUT_DIR" \ -DCOMPILER_RT_OUTPUT_DIR="$ANDROID_LIBRARY_OUTPUT_DIR" \
-DCOMPILER_RT_EXEC_OUTPUT_DIR="$ANDROID_EXEC_OUTPUT_DIR" \ -DCOMPILER_RT_EXEC_OUTPUT_DIR="$ANDROID_EXEC_OUTPUT_DIR" \
-DLLVM_LIT_ARGS="-sv --show-unsupported --show-xfail" \ -DLLVM_LIT_ARGS="-sv --show-unsupported --show-xfail" \
${CMAKE_COMMON_OPTIONS} \ ${CMAKE_COMMON_OPTIONS} \
${COMPILER_RT_OPTIONS} || echo @@@STEP_FAILURE@@@) & ${COMPILER_RT_OPTIONS} || echo @@@STEP_FAILURE@@@) &
} }
function build_android { function build_android {
▲ Show 20 Lines • Show All 155 Lines • Show Last 20 Lines