[GVN] permit forwarding to non-byte-sized loads
Needs ReviewPublic
Actions

Authored by vtjnash on Nov 3 2020, 11:50 AM.

Details

Reviewers

kuba
reames

Summary

This test was originally added in, but it's marked xfail in NewGVN. I think this seems to fix it.

commit 7470fb01d00e559eb9bed5fe00ba7feeb427d5f9
Author: Jakub Staszak <jstaszak@apple.com>
Date:   Fri Sep 2 14:57:37 2011 +0000

    Compare type size instead of type _store_ size to make sure that BitCastInst
    will be valid. This fixes PR10820.
    
    llvm-svn: 139005

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	380 ms	linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -mcmodel=large -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/hwasan/TestCases/sizes.cpp -nostdlib++ -lstdc++ -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/sizes.cpp.tmp
	360 ms	windows > lld.ELF/invalid::symtab-sh-info.s Script: -- : 'RUN: at line 4'; c:\ws\w64\llvm-project\premerge-checks\build\bin\yaml2obj.exe --docnum=1 C:\ws\w64\llvm-project\premerge-checks\lld\test\ELF\invalid\symtab-sh-info.s -o C:\ws\w64\llvm-project\premerge-checks\build\tools\lld\test\ELF\invalid\Output\symtab-sh-info.s.tmp.o

Event Timeline

vtjnash created this revision.Nov 3 2020, 11:50 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2020, 11:50 AM

Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript

vtjnash requested review of this revision.Nov 3 2020, 11:50 AM

fix test

use helper method

Harbormaster completed remote builds in B77444: Diff 302652.Nov 3 2020, 12:34 PM

Harbormaster completed remote builds in B77442: Diff 302650.Nov 3 2020, 12:39 PM

Harbormaster completed remote builds in B77445: Diff 302654.

vtjnash edited the summary of this revision. (Show Details)Nov 3 2020, 1:11 PM

vtjnash added a reviewer: reames.

Herald added a subscriber: Prazek. · View Herald TranscriptNov 3 2020, 1:11 PM

vtjnash added a reviewer: kuba.Nov 23 2020, 5:32 PM

The work had already pretty much been done before (for GVN), we just needed to
allow it to use that work here for NewGVN, and use bits directly rather than
bytes/8*8 for the output computation.

Harbormaster completed remote builds in B138236: Diff 392869.Dec 8 2021, 1:30 PM

reames resigned from this revision.Dec 10 2021, 9:13 AM