This is an archive of the discontinued LLVM Phabricator instance.

[GVN] permit forwarding to non-byte-sized loads
Needs ReviewPublic

Authored by vtjnash on Nov 3 2020, 11:50 AM.



This test was originally added in, but it's marked xfail in NewGVN. I think this seems to fix it.

commit 7470fb01d00e559eb9bed5fe00ba7feeb427d5f9
Author: Jakub Staszak <>
Date:   Fri Sep 2 14:57:37 2011 +0000

    Compare type size instead of type _store_ size to make sure that BitCastInst
    will be valid. This fixes PR10820.
    llvm-svn: 139005

Diff Detail

Event Timeline

vtjnash created this revision.Nov 3 2020, 11:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2020, 11:50 AM
vtjnash requested review of this revision.Nov 3 2020, 11:50 AM
vtjnash updated this revision to Diff 302654.Nov 3 2020, 12:01 PM

use helper method

Harbormaster completed remote builds in B77445: Diff 302654.
vtjnash edited the summary of this revision. (Show Details)Nov 3 2020, 1:11 PM
vtjnash added a reviewer: reames.
vtjnash updated this revision to Diff 392869.Dec 8 2021, 12:17 PM

The work had already pretty much been done before (for GVN), we just needed to
allow it to use that work here for NewGVN, and use bits directly rather than
bytes/8*8 for the output computation.

reames resigned from this revision.Dec 10 2021, 9:13 AM