Page MenuHomePhabricator

[lld][ELF][test] test LTO-removed symbols are not in symtab
ClosedPublic

Authored by edd on Nov 3 2020, 5:41 AM.

Details

Summary

Test that symbols eliminated by LTO do not appear in
the final .symtab section.

Added with the intention of moving coverage out of an internal
testsuite.

Diff Detail

Event Timeline

edd created this revision.Nov 3 2020, 5:41 AM
edd requested review of this revision.Nov 3 2020, 5:41 AM

Instead of keeping adding new tests for some specific properties, I find many times reusing the existing tests is more appropriate. (People studying the behavior can read one file instead of several files with the same structure which just tests different properties). For this case the test can be added into lto/internalize-basic.ll

edd updated this revision to Diff 302782.Nov 4 2020, 2:04 AM

I have moved the checks to the suggested location - thanks.

MaskRay accepted this revision.Nov 4 2020, 9:17 AM

LGTM.

This revision is now accepted and ready to land.Nov 4 2020, 9:17 AM
This revision was automatically updated to reflect the committed changes.