This is an archive of the discontinued LLVM Phabricator instance.

Differential D90403

[OpenMP] Add NULL check in dispatcher debug output
ClosedPublic

Authored by Nawrin on Oct 29 2020, 9:01 AM.

Details

Reviewers
jlpeyton
jdoerfert
Commits
rG771f0fb92dc2: [OpenMP] Add NULL check in dispatcher debug output

Diff Detail

Event Timeline

Nawrin created this revision.Oct 29 2020, 9:01 AM
Herald added subscribers: guansong, yaxunl. · View Herald TranscriptOct 29 2020, 9:01 AM
Nawrin requested review of this revision.Oct 29 2020, 9:01 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptOct 29 2020, 9:01 AM
Herald added a subscriber: sstefan1. · View Herald Transcript
jdoerfert accepted this revision.Oct 29 2020, 9:33 AM

LGTM

This revision is now accepted and ready to land.Oct 29 2020, 9:33 AM
Harbormaster completed remote builds in B76924: Diff 301639.Oct 29 2020, 9:52 AM
jlpeyton accepted this revision.Oct 29 2020, 12:02 PM

LGTM as well

Nawrin added a comment.Oct 29 2020, 12:05 PM

@jlpeyton Could you please push the change for me?

Closed by commit rG771f0fb92dc2: [OpenMP] Add NULL check in dispatcher debug output (authored by jlpeyton). · Explain WhyOct 29 2020, 12:08 PM
This revision was automatically updated to reflect the committed changes.
jlpeyton added a commit: rG771f0fb92dc2: [OpenMP] Add NULL check in dispatcher debug output.

Revision Contents

PathSize
openmp/
runtime/
src/
3 lines

Diff 301705

openmp/runtime/src/kmp_dispatch.cpp

Show First 20 Lines • Show All 2,010 Lines • ▼ Show 20 Lines
#ifdef KMP_DEBUG #ifdef KMP_DEBUG
{ {
char *buff; char *buff;
// create format specifiers before the debug output // create format specifiers before the debug output
buff = __kmp_str_format( buff = __kmp_str_format(
"__kmp_dispatch_next: T#%%d serialized case: p_lb:%%%s " "__kmp_dispatch_next: T#%%d serialized case: p_lb:%%%s "
"p_ub:%%%s p_st:%%%s p_last:%%p %%d returning:%%d\n", "p_ub:%%%s p_st:%%%s p_last:%%p %%d returning:%%d\n",
traits_t<T>::spec, traits_t<T>::spec, traits_t<ST>::spec); traits_t<T>::spec, traits_t<T>::spec, traits_t<ST>::spec);
KD_TRACE(10, (buff, gtid, *p_lb, *p_ub, *p_st, p_last, *p_last, status)); KD_TRACE(10, (buff, gtid, *p_lb, *p_ub, *p_st, p_last,
(p_last ? *p_last : 0), status));
__kmp_str_free(&buff); __kmp_str_free(&buff);
} }
#endif #endif
#if INCLUDE_SSC_MARKS #if INCLUDE_SSC_MARKS
SSC_MARK_DISPATCH_NEXT(); SSC_MARK_DISPATCH_NEXT();
#endif #endif
OMPT_LOOP_END; OMPT_LOOP_END;
KMP_STATS_LOOP_END; KMP_STATS_LOOP_END;
▲ Show 20 Lines • Show All 604 Lines • Show Last 20 Lines