Perform the probing in the *cough* correct direction.
Related to https://github.com/rust-lang/rust/pull/77885#issuecomment-711062924
Differential D90216
[stack-clash] Fix probing of dynamic alloca serge-sans-paille on Oct 27 2020, 3:17 AM. Authored by
Details
Perform the probing in the *cough* correct direction. Related to https://github.com/rust-lang/rust/pull/77885#issuecomment-711062924
Diff Detail
Event TimelineComment Actions I tried the C reproducer from that Rust bug, and it turns out that alloca(0) was already fixed by D88548. But if I change that to a larger size, then it was skipping right over the probe loop. I confirmed that your change here does make it go through the loop. It would be nice to have tests that actually execute this stuff, rather than just relying on manual reviews of the expected assembly, but I don't know if that's feasible in the current infrastructure.
|