Fix SBError::SetErrorToGenericError

[werat]

Summary

SBError::SetErrorToGenericError should call Status::SetErrorToGenericError, not Status::SetErrorToErrno.

[teemperor]

Could you add a test for this? This should be enough:

diff --git a/lldb/test/API/python_api/sberror/TestSBError.py b/lldb/test/API/python_api/sberror/TestSBError.py
new file mode 100644
index 000000000000..91d5a334bff2
--- /dev/null
+++ b/lldb/test/API/python_api/sberror/TestSBError.py
@@ -0,0 +1,11 @@
+from lldbsuite.test.lldbtest import *
+
+class TestSBError(TestBase):
+
+    mydir = TestBase.compute_mydir(__file__)
+    NO_DEBUG_INFO_TESTCASE = True
+
+    def test_generic_error(self):
+      error = lldb.SBError()
+      error.SetErrorToGenericError()
+      self.assertEqual(error.GetType(), lldb.eErrorTypeGeneric)

Otherwise this LGTM, thanks for the patch!

[werat]

Add a test case.

[teemperor]

Thanks! I assume you don't have commit access, so I'll land this for you.

[werat]

Thanks! Yeah, I don't have commit access, thanks for landing it for me.

lldb/source/API/SBError.cpp

void SBError::SetErrorToErrno() {
   CreateIfNeeded();
   m_opaque_up->SetErrorToErrno();
 }
 
 void SBError::SetErrorToGenericError() {
   LLDB_RECORD_METHOD_NO_ARGS(void, SBError, SetErrorToGenericError);
 
   CreateIfNeeded();
-  m_opaque_up->SetErrorToErrno();
+  m_opaque_up->SetErrorToGenericError();
 }
 
 void SBError::SetErrorString(const char *err_str) {
   LLDB_RECORD_METHOD(void, SBError, SetErrorString, (const char *), err_str);
 
   CreateIfNeeded();
   m_opaque_up->SetErrorString(err_str);
 }

lldb/test/API/python_api/sberror/TestSBError.py

+"""Test the SBError APIs."""
+
+from lldbsuite.test.lldbtest import *
+
+class TestSBError(TestBase):
+
+    mydir = TestBase.compute_mydir(__file__)
+    NO_DEBUG_INFO_TESTCASE = True
+
+    def test_generic_error(self):
+        error = lldb.SBError()
+        error.SetErrorToGenericError()
+        self.assertEqual(error.GetType(), lldb.eErrorTypeGeneric)