This is an archive of the discontinued LLVM Phabricator instance.

Set generic error in SBError SetErrorToGenericError
Needs ReviewPublic

Authored by shivammittal99 on Jul 5 2020, 12:57 PM.

Details

Reviewers
teemperor
JDevlieghere
mib
Group Reviewers
Restricted Project
Summary

Signed-off-by: Shivam Mittal <shivammittal99@gmail.com>

Diff Detail

Event Timeline

shivammittal99 created this revision.Jul 5 2020, 12:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2020, 12:57 PM

I suspect this was a copy/paste mistake. Could you add a small test for this? Other than that this LGTM

JDevlieghere added a reviewer: Restricted Project.Jul 6 2020, 8:43 AM
kwk added a subscriber: kwk.Jul 15 2020, 5:43 AM

LGTM but a test would indeed be nice.

teemperor resigned from this revision.Oct 29 2020, 2:18 AM
teemperor added a subscriber: teemperor.

D90151 landed and addressed/tested this.

JDevlieghere resigned from this revision.Oct 29 2020, 10:24 AM
mib resigned from this revision.Aug 11 2022, 4:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2022, 4:47 PM