This is an archive of the discontinued LLVM Phabricator instance.

[libunwind] Add -Wno-dll-attribute-on-redeclaration when building for windows
ClosedPublic

Authored by mstorsjo on Oct 23 2020, 1:27 PM.

Reviewers

compnerd
rnk

Group Reviewers

Restricted Project

Commits

Summary

It's not worth trying to fix these warnings within libunwind, instead silence them.

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 23 2020, 1:27 PM

Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript

mstorsjo requested review of this revision.Oct 23 2020, 1:27 PM

Lgtm

I would be fine with adding the decoration to the headers as well, but this seems reasonable.

This revision is now accepted and ready to land.Oct 26 2020, 10:35 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

libunwind/

8 lines

	Show First 20 Lines • Show All 197 Lines • ▼ Show 20 Lines
	add_compile_flags_if_supported(-Wstrict-overflow=4)			add_compile_flags_if_supported(-Wstrict-overflow=4)
	add_compile_flags_if_supported(-Wunused-parameter)			add_compile_flags_if_supported(-Wunused-parameter)
	add_compile_flags_if_supported(-Wunused-variable)			add_compile_flags_if_supported(-Wunused-variable)
	add_compile_flags_if_supported(-Wwrite-strings)			add_compile_flags_if_supported(-Wwrite-strings)
	add_compile_flags_if_supported(-Wundef)			add_compile_flags_if_supported(-Wundef)

	add_compile_flags_if_supported(-Wno-suggest-override)			add_compile_flags_if_supported(-Wno-suggest-override)

				if (WIN32)
				# The headers lack matching dllexport attributes (_LIBUNWIND_EXPORT);
				# silence the warning instead of cluttering the headers (which aren't
				# necessarily the ones that the callers will use anyway) with the
				# attributes.
				add_compile_flags_if_supported(-Wno-dll-attribute-on-redeclaration)
				endif()

	if (LIBUNWIND_ENABLE_WERROR)			if (LIBUNWIND_ENABLE_WERROR)
	add_compile_flags_if_supported(-Werror)			add_compile_flags_if_supported(-Werror)
	add_compile_flags_if_supported(-WX)			add_compile_flags_if_supported(-WX)
	else()			else()
	add_compile_flags_if_supported(-Wno-error)			add_compile_flags_if_supported(-Wno-error)
	add_compile_flags_if_supported(-WX-)			add_compile_flags_if_supported(-WX-)
	endif()			endif()

	▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines