[libc++] Perform libc++ CI directly in the pipeline instead of triggering our own pipeline

[ldionne]

Summary

Otherwise, the artifacts uploaded in the libc++ jobs are not picked up
by the reporting job, which is in the premerge-checks pipeline.

[ldionne]

As we've discussed before, I would prefer to keep the libc++ CI pipeline separate since it provides a nicer view of everything that has run recently for libc++, without being cluttered by other projects. We're losing this here, but we're gaining proper reporting in Phabricator reviews, which I think is more important.

However, another way we could perhaps achieve proper reporting is if we moved the reporting step that's currently run in the premerge-checks pipeline into the libcxx-ci pipeline. Would that work? I assume the reporting step isn't strongly tied to the premerge-checks pipeline?

[goncharov]

In D90068#2351068, @ldionne wrote:

As we've discussed before, I would prefer to keep the libc++ CI pipeline separate since it provides a nicer view of everything that has run recently for libc++, without being cluttered by other projects. We're losing this here, but we're gaining proper reporting in Phabricator reviews, which I think is more important.

However, another way we could perhaps achieve proper reporting is if we moved the reporting step that's currently run in the premerge-checks pipeline into the libcxx-ci pipeline. Would that work? I assume the reporting step isn't strongly tied to the premerge-checks pipeline?

I think that it should be possible to modify reporting so it will look closer on the result of libcxx pipeline and keep it separate.
How do you image proper reporting should look like? Would you like to see links to the failed configurations (like we have for windows / linux), e.g. by adding "libcxx C++03" next to the build or something else? Note that I have not implemented parsing of unit test results yet.

[ldionne]

In D90068#2361518, @goncharov wrote:

In D90068#2351068, @ldionne wrote:

However, another way we could perhaps achieve proper reporting is if we moved the reporting step that's currently run in the premerge-checks pipeline into the libcxx-ci pipeline. Would that work? I assume the reporting step isn't strongly tied to the premerge-checks pipeline?

I think that it should be possible to modify reporting so it will look closer on the result of libcxx pipeline and keep it separate.
How do you image proper reporting should look like? Would you like to see links to the failed configurations (like we have for windows / linux), e.g. by adding "libcxx C++03" next to the build or something else?

I haven't really thought about how that should work, however I think it would make sense to give it exactly the same handling as the normal jobs on the premerge-checks pipeline (i.e. Linux and Windows currently).

If you think it's possible to keep the libcxx-ci in a separate pipeline, do you think it would be possible to have the link here point to the libcxx-ci pipeline directly?

[ldionne]

In D90068#2368181, @ldionne wrote:

If you think it's possible to keep the libcxx-ci in a separate pipeline, do you think it would be possible to have the link here point to the libcxx-ci pipeline directly?

Gentle ping.

[goncharov]

In D90068#2385379, @ldionne wrote:

In D90068#2368181, @ldionne wrote:

If you think it's possible to keep the libcxx-ci in a separate pipeline, do you think it would be possible to have the link here point to the libcxx-ci pipeline directly?

Gentle ping.

If you think it's possible to keep the libcxx-ci in a separate pipeline, do you think it would be possible to have the link here point to the libcxx-ci pipeline directly?

Yes, that should be possible. Will add a link soon! Sorry for the late reply

[goncharov]

In D90068#2411593, @goncharov wrote:

In D90068#2385379, @ldionne wrote:

In D90068#2368181, @ldionne wrote:

If you think it's possible to keep the libcxx-ci in a separate pipeline, do you think it would be possible to have the link here point to the libcxx-ci pipeline directly?

Gentle ping.

If you think it's possible to keep the libcxx-ci in a separate pipeline, do you think it would be possible to have the link here point to the libcxx-ci pipeline directly?

Yes, that should be possible. Will add a link soon! Sorry for the late reply

@ldionne Here is how it looks now:

failed configs for libcxx are mentioned in parentheses, parses unit test results

[ldionne]

In D90068#2417785, @goncharov wrote:

@ldionne Here is how it looks now:

failed configs for libcxx are mentioned in parentheses, parses unit test results

Nice! That looks really awesome. I can't wait to try it (it requires a revision to fail the tests though :-).

libcxx/utils/ci/buildkite-pipeline-premerge.sh

 #
 # This file generates a Buildkite pipeline that triggers the libc++ CI
 # job(s) if needed.
 # See https://buildkite.com/docs/agent/v3/cli-pipeline#pipeline-format.
 #
 # Invoked by CI on pre-merge check for a commit.
 #
 
-DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
-
 if ! git diff --name-only HEAD~1 | grep -q -E "libcxx/|libcxxabi/"; then
-  # libcxx is not affected
+  # libc++ and libc++abi are not affected
   exit 0
 fi
 
-reviewID="$(git log --format=%B -n 1 | sed -nE 's/^Review-ID:[[:space:]]*(.+)$/\1/p')"
-if [[ "${reviewID}" != "" ]]; then
-  buildMessage="https://llvm.org/${reviewID}"
-else
-  buildMessage="Push to branch ${BUILDKITE_BRANCH}"
-fi
-
-
-cat <<EOF
-steps:
-  - trigger: "libcxx-ci"
-    build:
-      message: "${buildMessage}"
-      commit: "${BUILDKITE_COMMIT}"
-      branch: "${BUILDKITE_BRANCH}"
-EOF
-
-
+THIS_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)"
+cat "${THIS_DIR}/buildkite-pipeline.yml"

libcxx/utils/ci/buildkite-pipeline-snapshot.sh

 #!/usr/bin/env bash
 #===----------------------------------------------------------------------===##
 #
 # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 # See https://llvm.org/LICENSE.txt for license information.
 # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 #
 #===----------------------------------------------------------------------===##
 
 #
 # This file generates a Buildkite pipeline that triggers the libc++ CI jobs.
 # See https://buildkite.com/docs/agent/v3/cli-pipeline#pipeline-format.
 #
 # Invoked by CI on full builds.
 #
 
-DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
-cat <<EOF
-steps:
-  - trigger: "libcxx-ci"
-    build:
-      message: "${BUILDKITE_MESSAGE}"
-      commit: "${BUILDKITE_COMMIT}"
-      branch: "${BUILDKITE_BRANCH}"
-EOF
+THIS_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)"
+cat "${THIS_DIR}/buildkite-pipeline.yml"