This is an archive of the discontinued LLVM Phabricator instance.

[Attributor] Deduce noalias for local global variables with a single use
AcceptedPublic

Authored by uenoku on Oct 14 2020, 10:41 AM.

Details

Summary

This patch introduces a deduction of noalias for local global variables with a single use.

Diff Detail

Event Timeline

uenoku created this revision.Oct 14 2020, 10:41 AM
Herald added a project: Restricted Project. · View Herald Transcript
uenoku requested review of this revision.Oct 14 2020, 10:41 AM
uenoku retitled this revision from [Attributor] Deduce noalias for local global variables with asingle use to [Attributor] Deduce noalias for local global variables with a single use.Oct 14 2020, 10:43 AM
uenoku edited the summary of this revision. (Show Details)
uenoku updated this revision to Diff 298188.Oct 14 2020, 10:54 AM

Small fix

LGTM, cool :)

llvm/lib/Transforms/IPO/AttributorAttributes.cpp
2430

Keep a TODO for things other than globals (don't know yet what but still ;) )

2441

Maybe even GlobalValue.

jdoerfert accepted this revision.Oct 14 2020, 11:42 AM
This revision is now accepted and ready to land.Oct 14 2020, 11:42 AM
uenoku updated this revision to Diff 298244.Oct 14 2020, 2:44 PM

Handle Global Value

uenoku marked an inline comment as done.Oct 14 2020, 2:48 PM
uenoku added inline comments.
llvm/lib/Transforms/IPO/AttributorAttributes.cpp
2441

Handling GlovalValue introduces many noalias for function pointers :)