Fix broken bitstream linking with lld when e_machine > 255

[chrivers]

Summary

In lld's ELF/InputFiles.cpp, getBitcodeMachineKind() is limited to uint8_t return type.

This works as long as EM_xxx is < 256, which is true for common architectures,
but not for all targets.

The corresponding ELF field (e_machine) can hold uint16_t.

[MaskRay]

all (experimental) targets.

"experimental" is not appropriate. Just "all targets"

The corresponding ELF field can hold uint16_t, so change getBitcodeMachineKind() to uint16_t as well.

Just mention that it is e_machine

[chrivers]

Thanks for the feedback - I've updated the description to match.

[MaskRay]

Looks great!

[chrivers]

Thanks for reviewing.

I don't have commit access - can someone help commit this?

(docs/Phabricator.rst says to mention that)

[MaskRay]

In D89185#2324038, @chrivers wrote:

Thanks for reviewing.

I don't have commit access - can someone help commit this?

(docs/Phabricator.rst says to mention that)

I can do that. Can you provide git commit --amend --author='name <email>'?

[chrivers]

Yes, please use:

git commit --amend --author='Christian Iversen <[e-mail]>'

Exciting. First llvm commit :)

lld/ELF/InputFiles.cpp

 }
 
 static ELFKind getBitcodeELFKind(const Triple &t) {
   if (t.isLittleEndian())
     return t.isArch64Bit() ? ELF64LEKind : ELF32LEKind;
   return t.isArch64Bit() ? ELF64BEKind : ELF32BEKind;
 }
 
-static uint8_t getBitcodeMachineKind(StringRef path, const Triple &t) {
+static uint16_t getBitcodeMachineKind(StringRef path, const Triple &t) {
   switch (t.getArch()) {
   case Triple::aarch64:
     return EM_AARCH64;
   case Triple::amdgcn:
   case Triple::r600:
     return EM_AMDGPU;
   case Triple::arm:
   case Triple::thumb: