This is an archive of the discontinued LLVM Phabricator instance.

Differential D89181

[lldb] [Process/FreeBSD] Mark methods override in RegisterContext*
ClosedPublic

Authored by mgorny on Oct 10 2020, 12:24 AM.

Details

Reviewers
emaste
krytarowski
Commits
rGd83cd73e9ddf: [lldb] [Process/FreeBSD] Mark methods override in RegisterContext*

Diff Detail

Event Timeline

mgorny created this revision.Oct 10 2020, 12:24 AM
Herald added subscribers: atanasyan, nemanjai. · View Herald TranscriptOct 10 2020, 12:24 AM
mgorny requested review of this revision.Oct 10 2020, 12:24 AM
krytarowski accepted this revision.Oct 10 2020, 2:40 AM
This revision is now accepted and ready to land.Oct 10 2020, 2:40 AM
Closed by commit rGd83cd73e9ddf: [lldb] [Process/FreeBSD] Mark methods override in RegisterContext* (authored by mgorny). · Explain WhyOct 10 2020, 9:56 AM
This revision was automatically updated to reflect the committed changes.
mgorny added a commit: rGd83cd73e9ddf: [lldb] [Process/FreeBSD] Mark methods override in RegisterContext*.
Herald added a project: Restricted Project. · View Herald TranscriptOct 10 2020, 9:56 AM
Herald added a subscriber: jrtc27. · View Herald Transcript

Revision Contents

Diff 297420

lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.h

Show All 14 Lines
class RegisterContextPOSIXProcessMonitor_arm : public RegisterContextPOSIX_arm, class RegisterContextPOSIXProcessMonitor_arm : public RegisterContextPOSIX_arm,
public POSIXBreakpointProtocol { public POSIXBreakpointProtocol {
public: public:
RegisterContextPOSIXProcessMonitor_arm( RegisterContextPOSIXProcessMonitor_arm(
lldb_private::Thread &thread, lldb_private::Thread &thread,
std::unique_ptr<RegisterInfoPOSIX_arm> register_info); std::unique_ptr<RegisterInfoPOSIX_arm> register_info);
protected: protected:
bool ReadGPR(); bool ReadGPR() override;
bool ReadFPR(); bool ReadFPR() override;
bool WriteGPR(); bool WriteGPR() override;
bool WriteFPR(); bool WriteFPR() override;
// lldb_private::RegisterContext // lldb_private::RegisterContext
bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value); bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value);
bool WriteRegister(const unsigned reg, bool WriteRegister(const unsigned reg,
const lldb_private::RegisterValue &value); const lldb_private::RegisterValue &value);
bool ReadRegister(const lldb_private::RegisterInfo *reg_info, bool ReadRegister(const lldb_private::RegisterInfo *reg_info,
lldb_private::RegisterValue &value); lldb_private::RegisterValue &value) override;
bool WriteRegister(const lldb_private::RegisterInfo *reg_info, bool WriteRegister(const lldb_private::RegisterInfo *reg_info,
const lldb_private::RegisterValue &value); const lldb_private::RegisterValue &value) override;
bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp); bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp); bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read, uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read,
bool write); bool write) override;
bool ClearHardwareWatchpoint(uint32_t hw_index); bool ClearHardwareWatchpoint(uint32_t hw_index) override;
bool HardwareSingleStep(bool enable); bool HardwareSingleStep(bool enable) override;
// POSIXBreakpointProtocol // POSIXBreakpointProtocol
bool UpdateAfterBreakpoint(); bool UpdateAfterBreakpoint() override;
unsigned GetRegisterIndexFromOffset(unsigned offset); unsigned GetRegisterIndexFromOffset(unsigned offset) override;
bool IsWatchpointHit(uint32_t hw_index); bool IsWatchpointHit(uint32_t hw_index) override;
bool ClearWatchpointHits(); bool ClearWatchpointHits() override;
lldb::addr_t GetWatchpointAddress(uint32_t hw_index); lldb::addr_t GetWatchpointAddress(uint32_t hw_index) override;
bool IsWatchpointVacant(uint32_t hw_index); bool IsWatchpointVacant(uint32_t hw_index) override;
bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read, bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read,
bool write, uint32_t hw_index); bool write, uint32_t hw_index) override;
uint32_t NumSupportedHardwareWatchpoints(); uint32_t NumSupportedHardwareWatchpoints() override;
private: private:
RegisterInfoPOSIX_arm::GPR m_gpr_arm; RegisterInfoPOSIX_arm::GPR m_gpr_arm;
RegisterInfoPOSIX_arm::FPU m_fpr; RegisterInfoPOSIX_arm::FPU m_fpr;
ProcessMonitor &GetMonitor(); ProcessMonitor &GetMonitor();
}; };
#endif #endif

lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm64.h

Show All 15 Linesclass RegisterContextPOSIXProcessMonitor_arm64
: public RegisterContextPOSIX_arm64, : public RegisterContextPOSIX_arm64,
public POSIXBreakpointProtocol { public POSIXBreakpointProtocol {
public: public:
RegisterContextPOSIXProcessMonitor_arm64( RegisterContextPOSIXProcessMonitor_arm64(
lldb_private::Thread &thread, lldb_private::Thread &thread,
std::unique_ptr<RegisterInfoPOSIX_arm64> register_info); std::unique_ptr<RegisterInfoPOSIX_arm64> register_info);
protected: protected:
bool ReadGPR(); bool ReadGPR() override;
bool ReadFPR(); bool ReadFPR() override;
bool WriteGPR(); bool WriteGPR() override;
bool WriteFPR(); bool WriteFPR() override;
// lldb_private::RegisterContext // lldb_private::RegisterContext
bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value); bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value);
bool WriteRegister(const unsigned reg, bool WriteRegister(const unsigned reg,
const lldb_private::RegisterValue &value); const lldb_private::RegisterValue &value);
bool ReadRegister(const lldb_private::RegisterInfo *reg_info, bool ReadRegister(const lldb_private::RegisterInfo *reg_info,
lldb_private::RegisterValue &value); lldb_private::RegisterValue &value) override;
bool WriteRegister(const lldb_private::RegisterInfo *reg_info, bool WriteRegister(const lldb_private::RegisterInfo *reg_info,
const lldb_private::RegisterValue &value); const lldb_private::RegisterValue &value) override;
bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp); bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp); bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read, uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read,
bool write); bool write) override;
bool ClearHardwareWatchpoint(uint32_t hw_index); bool ClearHardwareWatchpoint(uint32_t hw_index) override;
bool HardwareSingleStep(bool enable); bool HardwareSingleStep(bool enable) override;
// POSIXBreakpointProtocol // POSIXBreakpointProtocol
bool UpdateAfterBreakpoint(); bool UpdateAfterBreakpoint() override;
unsigned GetRegisterIndexFromOffset(unsigned offset); unsigned GetRegisterIndexFromOffset(unsigned offset) override;
bool IsWatchpointHit(uint32_t hw_index); bool IsWatchpointHit(uint32_t hw_index) override;
bool ClearWatchpointHits(); bool ClearWatchpointHits() override;
lldb::addr_t GetWatchpointAddress(uint32_t hw_index); lldb::addr_t GetWatchpointAddress(uint32_t hw_index) override;
bool IsWatchpointVacant(uint32_t hw_index); bool IsWatchpointVacant(uint32_t hw_index) override;
bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read, bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read,
bool write, uint32_t hw_index); bool write, uint32_t hw_index) override;
uint32_t NumSupportedHardwareWatchpoints(); uint32_t NumSupportedHardwareWatchpoints() override;
private: private:
RegisterInfoPOSIX_arm64::GPR m_gpr_arm64; // 64-bit general purpose registers. RegisterInfoPOSIX_arm64::GPR m_gpr_arm64; // 64-bit general purpose registers.
RegisterInfoPOSIX_arm64::FPU RegisterInfoPOSIX_arm64::FPU
m_fpr; // floating-point registers including extended register sets. m_fpr; // floating-point registers including extended register sets.
ProcessMonitor &GetMonitor(); ProcessMonitor &GetMonitor();
}; };
#endif #endif

lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.h

Show All 16 Linesclass RegisterContextPOSIXProcessMonitor_mips64
: public RegisterContextPOSIX_mips64, : public RegisterContextPOSIX_mips64,
public POSIXBreakpointProtocol { public POSIXBreakpointProtocol {
public: public:
RegisterContextPOSIXProcessMonitor_mips64( RegisterContextPOSIXProcessMonitor_mips64(
lldb_private::Thread &thread, uint32_t concrete_frame_idx, lldb_private::Thread &thread, uint32_t concrete_frame_idx,
lldb_private::RegisterInfoInterface *register_info); lldb_private::RegisterInfoInterface *register_info);
protected: protected:
bool ReadGPR(); bool ReadGPR() override;
bool ReadFPR(); bool ReadFPR() override;
bool WriteGPR(); bool WriteGPR() override;
bool WriteFPR(); bool WriteFPR() override;
// lldb_private::RegisterContext // lldb_private::RegisterContext
bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value); bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value);
bool WriteRegister(const unsigned reg, bool WriteRegister(const unsigned reg,
const lldb_private::RegisterValue &value); const lldb_private::RegisterValue &value);
bool ReadRegister(const lldb_private::RegisterInfo *reg_info, bool ReadRegister(const lldb_private::RegisterInfo *reg_info,
lldb_private::RegisterValue &value); lldb_private::RegisterValue &value) override;
bool WriteRegister(const lldb_private::RegisterInfo *reg_info, bool WriteRegister(const lldb_private::RegisterInfo *reg_info,
const lldb_private::RegisterValue &value); const lldb_private::RegisterValue &value) override;
bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp); bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp); bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read, uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read,
bool write); bool write) override;
bool ClearHardwareWatchpoint(uint32_t hw_index); bool ClearHardwareWatchpoint(uint32_t hw_index) override;
bool HardwareSingleStep(bool enable); bool HardwareSingleStep(bool enable) override;
// POSIXBreakpointProtocol // POSIXBreakpointProtocol
bool UpdateAfterBreakpoint(); bool UpdateAfterBreakpoint() override;
unsigned GetRegisterIndexFromOffset(unsigned offset); unsigned GetRegisterIndexFromOffset(unsigned offset) override;
bool IsWatchpointHit(uint32_t hw_index); bool IsWatchpointHit(uint32_t hw_index) override;
bool ClearWatchpointHits(); bool ClearWatchpointHits() override;
lldb::addr_t GetWatchpointAddress(uint32_t hw_index); lldb::addr_t GetWatchpointAddress(uint32_t hw_index) override;
bool IsWatchpointVacant(uint32_t hw_index); bool IsWatchpointVacant(uint32_t hw_index) override;
bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read, bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read,
bool write, uint32_t hw_index); bool write, uint32_t hw_index) override;
uint32_t NumSupportedHardwareWatchpoints(); uint32_t NumSupportedHardwareWatchpoints() override;
private: private:
uint64_t uint64_t
m_gpr_mips64[k_num_gpr_registers_mips64]; // general purpose registers. m_gpr_mips64[k_num_gpr_registers_mips64]; // general purpose registers.
ProcessMonitor &GetMonitor(); ProcessMonitor &GetMonitor();
}; };
#endif #endif

lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_powerpc.h

Show All 18 Lines
public: public:
RegisterContextPOSIXProcessMonitor_powerpc( RegisterContextPOSIXProcessMonitor_powerpc(
lldb_private::Thread &thread, uint32_t concrete_frame_idx, lldb_private::Thread &thread, uint32_t concrete_frame_idx,
lldb_private::RegisterInfoInterface *register_info); lldb_private::RegisterInfoInterface *register_info);
protected: protected:
bool IsVMX(); bool IsVMX();
bool ReadGPR(); bool ReadGPR() override;
bool ReadFPR(); bool ReadFPR() override;
bool ReadVMX(); bool ReadVMX() override;
bool WriteGPR(); bool WriteGPR() override;
bool WriteFPR(); bool WriteFPR() override;
bool WriteVMX(); bool WriteVMX() override;
// lldb_private::RegisterContext // lldb_private::RegisterContext
bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value); bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value);
bool WriteRegister(const unsigned reg, bool WriteRegister(const unsigned reg,
const lldb_private::RegisterValue &value); const lldb_private::RegisterValue &value);
bool ReadRegister(const lldb_private::RegisterInfo *reg_info, bool ReadRegister(const lldb_private::RegisterInfo *reg_info,
lldb_private::RegisterValue &value); lldb_private::RegisterValue &value) override;
bool WriteRegister(const lldb_private::RegisterInfo *reg_info, bool WriteRegister(const lldb_private::RegisterInfo *reg_info,
const lldb_private::RegisterValue &value); const lldb_private::RegisterValue &value) override;
bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp); bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp); bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read, uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read,
bool write); bool write) override;
bool ClearHardwareWatchpoint(uint32_t hw_index); bool ClearHardwareWatchpoint(uint32_t hw_index) override;
bool HardwareSingleStep(bool enable); bool HardwareSingleStep(bool enable) override;
// POSIXBreakpointProtocol // POSIXBreakpointProtocol
bool UpdateAfterBreakpoint(); bool UpdateAfterBreakpoint() override;
unsigned GetRegisterIndexFromOffset(unsigned offset); unsigned GetRegisterIndexFromOffset(unsigned offset) override;
bool IsWatchpointHit(uint32_t hw_index); bool IsWatchpointHit(uint32_t hw_index) override;
bool ClearWatchpointHits(); bool ClearWatchpointHits() override;
lldb::addr_t GetWatchpointAddress(uint32_t hw_index); lldb::addr_t GetWatchpointAddress(uint32_t hw_index) override;
bool IsWatchpointVacant(uint32_t hw_index); bool IsWatchpointVacant(uint32_t hw_index) override;
bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read, bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read,
bool write, uint32_t hw_index); bool write, uint32_t hw_index) override;
uint32_t NumSupportedHardwareWatchpoints(); uint32_t NumSupportedHardwareWatchpoints() override;
private: private:
ProcessMonitor &GetMonitor(); ProcessMonitor &GetMonitor();
}; };
#endif #endif

lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_x86.h

Show All 16 Linesclass RegisterContextPOSIXProcessMonitor_x86_64
: public RegisterContextPOSIX_x86, : public RegisterContextPOSIX_x86,
public POSIXBreakpointProtocol { public POSIXBreakpointProtocol {
public: public:
RegisterContextPOSIXProcessMonitor_x86_64( RegisterContextPOSIXProcessMonitor_x86_64(
lldb_private::Thread &thread, uint32_t concrete_frame_idx, lldb_private::Thread &thread, uint32_t concrete_frame_idx,
lldb_private::RegisterInfoInterface *register_info); lldb_private::RegisterInfoInterface *register_info);
protected: protected:
bool ReadGPR(); bool ReadGPR() override;
bool ReadFPR(); bool ReadFPR() override;
bool WriteGPR(); bool WriteGPR() override;
bool WriteFPR(); bool WriteFPR() override;
// lldb_private::RegisterContext // lldb_private::RegisterContext
bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value); bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value);
bool WriteRegister(const unsigned reg, bool WriteRegister(const unsigned reg,
const lldb_private::RegisterValue &value); const lldb_private::RegisterValue &value);
bool ReadRegister(const lldb_private::RegisterInfo *reg_info, bool ReadRegister(const lldb_private::RegisterInfo *reg_info,
lldb_private::RegisterValue &value); lldb_private::RegisterValue &value) override;
bool WriteRegister(const lldb_private::RegisterInfo *reg_info, bool WriteRegister(const lldb_private::RegisterInfo *reg_info,
const lldb_private::RegisterValue &value); const lldb_private::RegisterValue &value) override;
bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp); bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp); bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read, uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read,
bool write); bool write) override;
bool ClearHardwareWatchpoint(uint32_t hw_index); bool ClearHardwareWatchpoint(uint32_t hw_index) override;
bool HardwareSingleStep(bool enable); bool HardwareSingleStep(bool enable) override;
// POSIXBreakpointProtocol // POSIXBreakpointProtocol
bool UpdateAfterBreakpoint(); bool UpdateAfterBreakpoint() override;
unsigned GetRegisterIndexFromOffset(unsigned offset); unsigned GetRegisterIndexFromOffset(unsigned offset) override;
bool IsWatchpointHit(uint32_t hw_index); bool IsWatchpointHit(uint32_t hw_index) override;
bool ClearWatchpointHits(); bool ClearWatchpointHits() override;
lldb::addr_t GetWatchpointAddress(uint32_t hw_index); lldb::addr_t GetWatchpointAddress(uint32_t hw_index) override;
bool IsWatchpointVacant(uint32_t hw_index); bool IsWatchpointVacant(uint32_t hw_index) override;
bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read, bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read,
bool write, uint32_t hw_index); bool write, uint32_t hw_index) override;
uint32_t NumSupportedHardwareWatchpoints(); uint32_t NumSupportedHardwareWatchpoints() override;
private: private:
ProcessMonitor &GetMonitor(); ProcessMonitor &GetMonitor();
uint32_t uint32_t
m_fctrl_offset_in_userarea; // Offset of 'fctrl' in 'UserArea' Structure m_fctrl_offset_in_userarea; // Offset of 'fctrl' in 'UserArea' Structure
struct iovec m_iovec; struct iovec m_iovec;
}; };
#endif #endif