Page MenuHomePhabricator

Set the default for -bbsections-cold-text-prefix to .text.split.
AbandonedPublic

Authored by snehasish on Oct 7 2020, 11:50 AM.

Details

Reviewers
None
Summary

After using this for a while, we find that it is generally useful to
have it set to .text.split. by default, removing the need for an
additional -mllvm option.

Please ignore in favour of revision: https://reviews.llvm.org/D88997

Diff Detail

Unit TestsFailed

TimeTest
20 mslinux > Clang.Misc::warning-wall.c
Script: -- : 'RUN: at line 1'; diagtool tree -Wall > /mnt/disks/ssd0/agent/llvm-project/build/tools/clang/test/Misc/Output/warning-wall.c.tmp 2>&1
40 mslinux > LLVM.CodeGen/X86::basic-block-sections-clusters-branches.ll
Script: -- : 'RUN: at line 7'; echo '!foo' > /mnt/disks/ssd0/agent/llvm-project/build/test/CodeGen/X86/Output/basic-block-sections-clusters-branches.ll.tmp1
50 mslinux > LLVM.CodeGen/X86::basic-block-sections-clusters.ll
Script: -- : 'RUN: at line 6'; echo '!foo' > /mnt/disks/ssd0/agent/llvm-project/build/test/CodeGen/X86/Output/basic-block-sections-clusters.ll.tmp1
40 mslinux > LLVM.CodeGen/X86::basic-block-sections-cold.ll
Script: -- : 'RUN: at line 3'; echo '!_Z3bazb' > /mnt/disks/ssd0/agent/llvm-project/build/test/CodeGen/X86/Output/basic-block-sections-cold.ll.tmp
60 mslinux > LLVM.CodeGen/X86::machine-function-splitter.ll
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/llc < /mnt/disks/ssd0/agent/llvm-project/llvm/test/CodeGen/X86/machine-function-splitter.ll -mtriple=x86_64-unknown-linux-gnu -split-machine-functions | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/llvm/test/CodeGen/X86/machine-function-splitter.ll -check-prefix=MFS-DEFAULTS

Event Timeline

snehasish created this revision.Oct 7 2020, 11:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2020, 11:50 AM
snehasish requested review of this revision.Oct 7 2020, 11:50 AM
snehasish abandoned this revision.Oct 7 2020, 11:56 AM
snehasish edited the summary of this revision. (Show Details)
snehasish removed reviewers: tmsriram, echristo.