This is an archive of the discontinued LLVM Phabricator instance.

Differential D88951

[Tablegen][SubtargetEmitter] Print TuneCPU in Subtarget::ParseSubtargetFeatures
ClosedPublic

Authored by kito-cheng on Oct 7 2020, 2:12 AM.

Details

Reviewers
craig.topper
Commits
rG6bf25f45a9b6: [Tablegen][SubtargetEmitter] Print TuneCPU in Subtarget::ParseSubtargetFeatures
Summary

Let user able to know which -tune-cpu are used now.

Diff Detail

Unit TestsFailed

TimeTest
2,760 mslinux > lldb-api.functionalities/thread/concurrent_events::TestConcurrentDelaySignalWatch.py

Event Timeline

kito-cheng created this revision.Oct 7 2020, 2:12 AM
Herald added subscribers: llvm-commits, pengfei. · View Herald TranscriptOct 7 2020, 2:12 AM
kito-cheng requested review of this revision.Oct 7 2020, 2:12 AM
Harbormaster completed remote builds in B74239: Diff 296624.Oct 7 2020, 2:36 AM
craig.topper accepted this revision.Oct 7 2020, 8:03 AM

LGTM

This revision is now accepted and ready to land.Oct 7 2020, 8:03 AM
This revision was landed with ongoing or failed builds.Oct 11 2020, 11:47 PM
Closed by commit rG6bf25f45a9b6: [Tablegen][SubtargetEmitter] Print TuneCPU in Subtarget::ParseSubtargetFeatures (authored by kito-cheng). · Explain Why
This revision was automatically updated to reflect the committed changes.
Kito Cheng <kito.cheng@sifive.com> added a commit: rG6bf25f45a9b6: [Tablegen][SubtargetEmitter] Print TuneCPU in Subtarget::ParseSubtargetFeatures.

Revision Contents

PathSize
llvm/
utils/
TableGen/
3 lines

Diff 296624

llvm/utils/TableGen/SubtargetEmitter.cpp

Show First 20 Lines • Show All 1,694 Lines • ▼ Show 20 Linesvoid SubtargetEmitter::ParseFeaturesFunction(raw_ostream &OS,
OS << "// ParseSubtargetFeatures - Parses features string setting specified\n" OS << "// ParseSubtargetFeatures - Parses features string setting specified\n"
<< "// subtarget options.\n" << "// subtarget options.\n"
<< "void llvm::"; << "void llvm::";
OS << Target; OS << Target;
OS << "Subtarget::ParseSubtargetFeatures(StringRef CPU, StringRef TuneCPU, " OS << "Subtarget::ParseSubtargetFeatures(StringRef CPU, StringRef TuneCPU, "
<< "StringRef FS) {\n" << "StringRef FS) {\n"
<< " LLVM_DEBUG(dbgs() << \"\\nFeatures:\" << FS);\n" << " LLVM_DEBUG(dbgs() << \"\\nFeatures:\" << FS);\n"
<< " LLVM_DEBUG(dbgs() << \"\\nCPU:\" << CPU << \"\\n\\n\");\n"; << " LLVM_DEBUG(dbgs() << \"\\nCPU:\" << CPU);\n"
<< " LLVM_DEBUG(dbgs() << \"\\nTuneCPU:\" << TuneCPU << \"\\n\\n\");\n";
if (Features.empty()) { if (Features.empty()) {
OS << "}\n"; OS << "}\n";
return; return;
} }
OS << " InitMCProcessorInfo(CPU, TuneCPU, FS);\n" OS << " InitMCProcessorInfo(CPU, TuneCPU, FS);\n"
<< " const FeatureBitset& Bits = getFeatureBits();\n"; << " const FeatureBitset& Bits = getFeatureBits();\n";
▲ Show 20 Lines • Show All 249 Lines • Show Last 20 Lines