This is an archive of the discontinued LLVM Phabricator instance.

Differential D88763

[fuzzer] Remove unused variable
ClosedPublic

Authored by yln on Oct 2 2020, 4:21 PM.

Details

Reviewers
kcc
morehouse
delcypher
Commits
rGc56bb45e8399: [fuzzer] Remove unused variable
Summary

TempAutoDictionary is never used. Maybe a leftover of a previous
experiment?

Diff Detail

Unit TestsFailed

TimeTest
100 mslinux > Clang.Driver::fuchsia.cpp

Event Timeline

yln created this revision.Oct 2 2020, 4:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 2 2020, 4:21 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
yln requested review of this revision.Oct 2 2020, 4:21 PM
yln added reviewers: kcc, morehouse, delcypher.Oct 2 2020, 4:24 PM
morehouse accepted this revision.Oct 2 2020, 4:30 PM

LGTM

This revision is now accepted and ready to land.Oct 2 2020, 4:30 PM
Harbormaster completed remote builds in B73845: Diff 295928.Oct 2 2020, 4:31 PM
This revision was landed with ongoing or failed builds.Oct 2 2020, 4:33 PM
Closed by commit rGc56bb45e8399: [fuzzer] Remove unused variable (authored by yln). · Explain Why
This revision was automatically updated to reflect the committed changes.
yln added a commit: rGc56bb45e8399: [fuzzer] Remove unused variable.

Revision Contents

PathSize
compiler-rt/
lib/
fuzzer/
3 lines

Diff 295928

compiler-rt/lib/fuzzer/FuzzerMutate.h

//===- FuzzerMutate.h - Internal header for the Fuzzer ----------*- C++ -* ===// //===- FuzzerMutate.h - Internal header for the Fuzzer ----------*- C++ -* ===//
Lint: Lint
Inline Actions

clang-format not found in user's PATH; not linting file.

Lint: Lint: clang-format not found in user's PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// fuzzer::MutationDispatcher // fuzzer::MutationDispatcher
▲ Show 20 Lines • Show All 115 Lines • ▼ Show 20 Lines DictionaryEntry MakeDictionaryEntryFromCMP(const void *Arg1, const void *Arg2,
size_t ArgSize, size_t ArgSize,
const uint8_t *Data, size_t Size); const uint8_t *Data, size_t Size);
Random &Rand; Random &Rand;
const FuzzingOptions Options; const FuzzingOptions Options;
// Dictionary provided by the user via -dict=DICT_FILE. // Dictionary provided by the user via -dict=DICT_FILE.
Dictionary ManualDictionary; Dictionary ManualDictionary;
// Temporary dictionary modified by the fuzzer itself,
// recreated periodically.
Dictionary TempAutoDictionary;
// Persistent dictionary modified by the fuzzer, consists of // Persistent dictionary modified by the fuzzer, consists of
// entries that led to successful discoveries in the past mutations. // entries that led to successful discoveries in the past mutations.
Dictionary PersistentAutoDictionary; Dictionary PersistentAutoDictionary;
Vector<DictionaryEntry *> CurrentDictionaryEntrySequence; Vector<DictionaryEntry *> CurrentDictionaryEntrySequence;
static const size_t kCmpDictionaryEntriesDequeSize = 16; static const size_t kCmpDictionaryEntriesDequeSize = 16;
DictionaryEntry CmpDictionaryEntriesDeque[kCmpDictionaryEntriesDequeSize]; DictionaryEntry CmpDictionaryEntriesDeque[kCmpDictionaryEntriesDequeSize];
Show All 17 Lines