This is an archive of the discontinued LLVM Phabricator instance.

[06/10] ELF/AArch64: Check linker created dynamic variables
ClosedPublic

Authored by zatrazz on Apr 7 2015, 7:30 AM.

Details

Summary

Hi ruiu, shankarke,

This is re-post of a previous attempt. Check the values of _GLOBAL_OFFSET_TABLE_ and _DYNAMIC variables created by linker. This is a AArch64 version based on existing x86_64 one.

Diff Detail

Event Timeline

zatrazz updated this revision to Diff 23332.Apr 7 2015, 7:30 AM
zatrazz retitled this revision from to [06/10] ELF/AArch64: Check linker created dynamic variables.
zatrazz updated this object.
zatrazz edited the test plan for this revision. (Show Details)
zatrazz added reviewers: ruiu, shankar.easwaran.
zatrazz added a project: lld.
zatrazz added subscribers: Unknown Object (MLST), lld.
ruiu accepted this revision.Apr 7 2015, 9:28 AM
ruiu edited edge metadata.

LGTM

test/elf/AArch64/dynamicvars.test
6

nit: put a space after the hashes.

You can remove "-check-prefix CHECKSYMS" from this command line and s/CHECKSYMS/CHECK/ below because this file contains only one FileCheck.

20

ditto

This revision is now accepted and ready to land.Apr 7 2015, 9:28 AM

Thanks, I will change it and remove the CHECKSYMS prefix.

zatrazz closed this revision.Apr 21 2015, 11:15 AM