This is an archive of the discontinued LLVM Phabricator instance.

Differential D88476

[OpenMP][VE plugin] Fixing failure to build VE plugin with consolidated error handling in libomptarget
ClosedPublic

Authored by manorom on Sep 29 2020, 4:09 AM.

Details

Reviewers
simoll
jdoerfert
Commits
rGc816ee13ad9e: [OpenMP][VE plugin] Fixing failure to build VE plugin with consolidated error…
Summary

The libomptarget VE plugin fails zu build after ae95ceeb8f98d81f615c69da02f73b5ee6b1519a .

Diff Detail

Event Timeline

manorom created this revision.Sep 29 2020, 4:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2020, 4:09 AM
Herald added subscribers: openmp-commits, guansong, yaxunl. · View Herald Transcript
manorom requested review of this revision.Sep 29 2020, 4:09 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptSep 29 2020, 4:09 AM
Herald added a subscriber: sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B73309: Diff 294926.Sep 29 2020, 4:24 AM
simoll accepted this revision.Sep 29 2020, 4:49 AM

Thanks!

This revision is now accepted and ready to land.Sep 29 2020, 4:49 AM
This revision was landed with ongoing or failed builds.Sep 29 2020, 8:39 AM
Closed by commit rGc816ee13ad9e: [OpenMP][VE plugin] Fixing failure to build VE plugin with consolidated error… (authored by manorom, committed by simoll). · Explain Why
This revision was automatically updated to reflect the committed changes.
simoll added a commit: rGc816ee13ad9e: [OpenMP][VE plugin] Fixing failure to build VE plugin with consolidated error….

Revision Contents

PathSize
openmp/
libomptarget/
plugins/
ve/
src/
14 lines

Diff 294926

openmp/libomptarget/plugins/ve/src/rtl.cpp

//===-RTLs/nec-aurora/src/rtl.cpp - Target RTLs Implementation - C++ -*-======// //===-RTLs/nec-aurora/src/rtl.cpp - Target RTLs Implementation - C++ -*-======//
Lint: Lint
Inline Actions

clang-format not found in user's PATH; not linting file.

Lint: Lint: clang-format not found in user's PATH; not linting file.
// //
// The LLVM Compiler Infrastructure // The LLVM Compiler Infrastructure
// //
// This file is dual licensed under the MIT and the University of Illinois Open // This file is dual licensed under the MIT and the University of Illinois Open
// Source Licenses. See LICENSE.txt for details. // Source Licenses. See LICENSE.txt for details.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// RTL for NEC Aurora TSUBASA machines // RTL for NEC Aurora TSUBASA machines
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "Debug.h"
#include "omptargetplugin.h"
#include <algorithm> #include <algorithm>
#include <cassert> #include <cassert>
#include <cerrno> #include <cerrno>
#include <cstring> #include <cstring>
#include <list> #include <list>
#include <stdlib.h> #include <stdlib.h>
#include <string> #include <string>
#include <sys/stat.h> #include <sys/stat.h>
#include <ve_offload.h> #include <ve_offload.h>
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: 've_offload.h' file not found [clang-diagnostic-error]
not useful

Lint: Pre-merge checks: clang-tidy: error: 've_offload.h' file not found [clang-diagnostic-error] [[https://github.
#include <vector> #include <vector>
#include <veosinfo/veosinfo.h> #include <veosinfo/veosinfo.h>
#ifndef TARGET_ELF_ID #include "Debug.h"
#define TARGET_ELF_ID 0 #include "omptargetplugin.h"
#endif
#ifndef TARGET_NAME
#define TARGET_NAME VE #define TARGET_NAME VE
#endif
#define DEBUG_PREFIX "Target " GETNAME(TARGET_NAME) " RTL" #define DEBUG_PREFIX "Target " GETNAME(TARGET_NAME) " RTL"
#ifndef TARGET_ELF_ID
#define TARGET_ELF_ID 0
#endif
#include "../../common/elf_common.c" #include "../../common/elf_common.c"
struct DynLibTy { struct DynLibTy {
char *FileName; char *FileName;
uint64_t VeoLibHandle; uint64_t VeoLibHandle;
}; };
/// Keep entries table per device. /// Keep entries table per device.
▲ Show 20 Lines • Show All 404 Lines • Show Last 20 Lines