This is an archive of the discontinued LLVM Phabricator instance.

[Docs][NewPM] Add note about required passes
ClosedPublic

Authored by aeubanks on Sep 25 2020, 3:23 PM.

Diff Detail

Unit TestsFailed

Event Timeline

aeubanks created this revision.Sep 25 2020, 3:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 25 2020, 3:23 PM
aeubanks requested review of this revision.Sep 25 2020, 3:23 PM
ychen added a comment.Sep 25 2020, 4:32 PM

Thank you for writing this down.

llvm/docs/WritingAnLLVMNewPMPass.rst
217

Personally, I may reorder the structure a little bit:

(definition) A pass that defines a static isRequired() method that returns true is a required pass.
< ... example ...>
(motivation) - meta passes (pass manager, adaptor pass etc) - user passes: AlwaysInlinerPass etc.
(behavior) override all other mechanisms that may skip a pass, like "optnone" etc.

aeubanks updated this revision to Diff 294606.Sep 27 2020, 11:04 PM

rework documentation

ychen accepted this revision.Sep 28 2020, 12:59 PM

LGTM

This revision is now accepted and ready to land.Sep 28 2020, 12:59 PM
This revision was automatically updated to reflect the committed changes.