This is an archive of the discontinued LLVM Phabricator instance.

[ConstantRange] Make binaryNot() more precise
AbandonedPublic

Authored by nikic on Sep 23 2020, 11:54 AM.

Details

Reviewers
lebedev.ri
Summary

@lebedev.ri This is what I had in mind. The code is correct and more precise without the check for wrapping sets, we just need a different testing function that can deal with wrapping ranges.

Diff Detail

Event Timeline

nikic created this revision.Sep 23 2020, 11:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2020, 11:54 AM
nikic requested review of this revision.Sep 23 2020, 11:54 AM

Guess i'll just have to do it myself then.

Rebase please

nikic added a comment.Sep 24 2020, 3:07 PM

Guess i'll just have to do it myself then.

I feel like I'm missing context here. Did I overlook review feedback somewhere?

Guess i'll just have to do it myself then.

I feel like I'm missing context here. Did I overlook review feedback somewhere?

This is fixing something for which we essentially lack test coverage. Test coverage i complained we lack.