This is an archive of the discontinued LLVM Phabricator instance.

Differential D88101

address review comment
Needs ReviewPublic

Authored by kiszk on Sep 22 2020, 8:50 AM.
This revision needs review, but all reviewers have resigned.

Details

Reviewers
nicolasvasilache

Diff Detail

Event Timeline

kiszk created this revision.Sep 22 2020, 8:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2020, 8:50 AM
Herald added subscribers: tatianashp, msifontes, jurahul and 13 others. · View Herald Transcript
kiszk requested review of this revision.Sep 22 2020, 8:50 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptSep 22 2020, 8:50 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B72526: Diff 293472.Sep 22 2020, 8:50 AM
kiszk added a comment.Sep 22 2020, 9:20 AM

I am sorry for my mistake. Please ignore this.

nicolasvasilache resigned from this revision.Oct 12 2020, 4:26 AM
Herald added a subscriber: rdzhabarov. · View Herald TranscriptOct 12 2020, 4:26 AM

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
Affine/
IR/
2 lines

Diff 293472

mlir/include/mlir/Dialect/Affine/IR/AffineOps.td

Show First 20 Lines • Show All 624 Lines • ▼ Show 20 Lines let description = [{
Note: Calling AffineParallelOp::build will create the required region and Note: Calling AffineParallelOp::build will create the required region and
block, and insert the required terminator if it is trivial (i.e. no values block, and insert the required terminator if it is trivial (i.e. no values
are yielded). Parsing will also create the required region, block, and are yielded). Parsing will also create the required region, block, and
terminator, even when they are missing from the textual representation. terminator, even when they are missing from the textual representation.
Example (3x3 valid convolution): Example (3x3 valid convolution):
```mlir ```mlir
function @conv_2d(%D : memref<100x100xf32>, %K : memref<3x3xf32>) -> (memref<98x98xf32>) { func @conv_2d(%D : memref<100x100xf32>, %K : memref<3x3xf32>) -> (memref<98x98xf32>) {
%O = alloc memref<98x98xf32> %O = alloc memref<98x98xf32>
affine.parallel (%x, %y) = (0, 0) to (98, 98) { affine.parallel (%x, %y) = (0, 0) to (98, 98) {
%0 = affine.parallel (%kx, %ky) = (0, 0) to (2, 2) reduce ("addf") { %0 = affine.parallel (%kx, %ky) = (0, 0) to (2, 2) reduce ("addf") {
%1 = affine.load %D[%x + %kx, %y + %ky] : memref<100x100xf32> %1 = affine.load %D[%x + %kx, %y + %ky] : memref<100x100xf32>
%2 = affine.load %K[%kx, %ky] : memref<3x3xf32> %2 = affine.load %K[%kx, %ky] : memref<3x3xf32>
%3 = mulf %1, %2 : f32 %3 = mulf %1, %2 : f32
affine.yield %3 : f32 affine.yield %3 : f32
} }
▲ Show 20 Lines • Show All 346 Lines • Show Last 20 Lines