This is an archive of the discontinued LLVM Phabricator instance.

Differential D88073

[DWARFYAML][test] Simplify __debug_pubnames/types tests. NFC.
ClosedPublic

Authored by Higuoxing on Sep 22 2020, 12:18 AM.

Details

Reviewers
jhenderson
grimar
MaskRay
Commits
rG64435a427a01: [DWARFYAML][test] Simplify __debug_pubnames/types tests. NFC.
Summary

This patch stripped unneeded sections from the test case.

Diff Detail

Event Timeline

Higuoxing created this revision.Sep 22 2020, 12:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2020, 12:18 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Higuoxing requested review of this revision.Sep 22 2020, 12:18 AM
Harbormaster completed remote builds in B72478: Diff 293359.Sep 22 2020, 12:51 AM
grimar accepted this revision.Sep 22 2020, 1:06 AM

I am not an expert in MachO, but this change looks good and reasonable to me. Worth waiting for a second opinion.

This revision is now accepted and ready to land.Sep 22 2020, 1:06 AM
MaskRay accepted this revision.Sep 22 2020, 9:38 AM

LGTM.

Closed by commit rG64435a427a01: [DWARFYAML][test] Simplify __debug_pubnames/types tests. NFC. (authored by Higuoxing). · Explain WhySep 22 2020, 5:43 PM
This revision was automatically updated to reflect the committed changes.
Higuoxing added a commit: rG64435a427a01: [DWARFYAML][test] Simplify __debug_pubnames/types tests. NFC..

Revision Contents

PathSize
llvm/
test/
ObjectYAML/
MachO/
314 lines

Diff 293605

llvm/test/ObjectYAML/MachO/DWARF-pubsections.yaml

## This file contains test cases for generating .debug_pubnames/.debug_pubtypes ## This file contains test cases for generating .debug_pubnames/.debug_pubtypes
## section in object files from the DWARF entry of Mach-O YAML inputs ## section in object files from the DWARF entry of Mach-O YAML inputs
## a) Test that yaml2obj emits the .debug_pubnames and .debug_pubtypes sections and ## a) Test that yaml2obj emits the .debug_pubnames and .debug_pubtypes sections and
## obj2yaml converts them back. ## obj2yaml converts them back.
# RUN: yaml2obj %s | obj2yaml | FileCheck %s # RUN: yaml2obj %s | obj2yaml | FileCheck %s
--- !mach-o --- !mach-o
FileHeader: FileHeader:
magic: 0xFEEDFACF magic: 0xFEEDFACF
cputype: 0x01000007 cputype: 0x01000007
cpusubtype: 0x00000003 cpusubtype: 0x00000003
filetype: 0x0000000A filetype: 0x0000000A
ncmds: 5 ncmds: 1
sizeofcmds: 1800 sizeofcmds: 1800
flags: 0x00000000 flags: 0x00000000
reserved: 0x00000000 reserved: 0x00000000
LoadCommands: LoadCommands:
- cmd: LC_SEGMENT_64 - cmd: LC_SEGMENT_64
cmdsize: 72 cmdsize: 232
segname: __PAGEZERO segname: __DWARF
vmaddr: 0 vmaddr: 0
vmsize: 4294967296 vmsize: 0
fileoff: 0 fileoff: 152
filesize: 0 filesize: 0xffff
maxprot: 0 maxprot: 0
initprot: 0 initprot: 0
nsects: 0
flags: 0
- cmd: LC_SEGMENT_64
cmdsize: 472
segname: __TEXT
vmaddr: 4294967296
vmsize: 4096
fileoff: 0
filesize: 0
maxprot: 7
initprot: 5
nsects: 5
flags: 0
Sections:
- sectname: __text
segname: __TEXT
addr: 0x0000000100000F50
size: 52
offset: 0x00000000
align: 4
reloff: 0x00000000
nreloc: 0
flags: 0x80000400
reserved1: 0x00000000
reserved2: 0x00000000
reserved3: 0x00000000
- sectname: __stubs
segname: __TEXT
addr: 0x0000000100000F84
size: 6
offset: 0x00000000
align: 1
reloff: 0x00000000
nreloc: 0
flags: 0x80000408
reserved1: 0x00000000
reserved2: 0x00000006
reserved3: 0x00000000
- sectname: __stub_helper
segname: __TEXT
addr: 0x0000000100000F8C
size: 26
offset: 0x00000000
align: 2
reloff: 0x00000000
nreloc: 0
flags: 0x80000400
reserved1: 0x00000000
reserved2: 0x00000000
reserved3: 0x00000000
- sectname: __cstring
segname: __TEXT
addr: 0x0000000100000FA6
size: 14
offset: 0x00000000
align: 0
reloff: 0x00000000
nreloc: 0
flags: 0x00000002
reserved1: 0x00000000
reserved2: 0x00000000
reserved3: 0x00000000
- sectname: __unwind_info
segname: __TEXT
addr: 0x0000000100000FB4
size: 72
offset: 0x00000000
align: 2
reloff: 0x00000000
nreloc: 0
flags: 0x00000000
reserved1: 0x00000000
reserved2: 0x00000000
reserved3: 0x00000000
- cmd: LC_SEGMENT_64
cmdsize: 232
segname: __DATA
vmaddr: 4294971392
vmsize: 4096
fileoff: 0
filesize: 0
maxprot: 7
initprot: 3
nsects: 2 nsects: 2
flags: 0 flags: 0
Sections: Sections:
- sectname: __nl_symbol_ptr
segname: __DATA
addr: 0x0000000100001000
size: 16
offset: 0x00000000
align: 3
reloff: 0x00000000
nreloc: 0
flags: 0x00000006
reserved1: 0x00000001
reserved2: 0x00000000
reserved3: 0x00000000
- sectname: __la_symbol_ptr
segname: __DATA
addr: 0x0000000100001010
size: 8
offset: 0x00000000
align: 3
reloff: 0x00000000
nreloc: 0
flags: 0x00000007
reserved1: 0x00000003
reserved2: 0x00000000
reserved3: 0x00000000
- cmd: LC_SEGMENT_64
cmdsize: 72
segname: __LINKEDIT
vmaddr: 4294975488
vmsize: 4096
fileoff: 4096
filesize: 60
maxprot: 7
initprot: 1
nsects: 0
flags: 0
- cmd: LC_SEGMENT_64
cmdsize: 952
segname: __DWARF
vmaddr: 4294979584
vmsize: 4096
fileoff: 8192
filesize: 764
maxprot: 7
initprot: 3
nsects: 11
flags: 0
Sections:
- sectname: __debug_line
segname: __DWARF
addr: 0x0000000100003000
size: 69
offset: 0x00002000
align: 0
reloff: 0x00000000
nreloc: 0
flags: 0x00000000
reserved1: 0x00000000
reserved2: 0x00000000
reserved3: 0x00000000
- sectname: __debug_pubnames - sectname: __debug_pubnames
segname: __DWARF segname: __DWARF
addr: 0x0000000100003045 addr: 0x0000000000000000
size: 27 size: 27
offset: 0x00002045 offset: 0x00000152
align: 0 align: 0
reloff: 0x00000000 reloff: 0x00000000
nreloc: 0 nreloc: 0
flags: 0x00000000 flags: 0x00000000
reserved1: 0x00000000 reserved1: 0x00000000
reserved2: 0x00000000 reserved2: 0x00000000
reserved3: 0x00000000 reserved3: 0x00000000
- sectname: __debug_pubtypes - sectname: __debug_pubtypes
segname: __DWARF segname: __DWARF
addr: 0x0000000100003060 addr: 0x0000000000000000
size: 35 size: 35
offset: 0x00002060 offset: 0x00000720
align: 0
reloff: 0x00000000
nreloc: 0
flags: 0x00000000
reserved1: 0x00000000
reserved2: 0x00000000
reserved3: 0x00000000
- sectname: __debug_info
segname: __DWARF
addr: 0x00000001000030B3
size: 121
offset: 0x000020B3
align: 0
reloff: 0x00000000
nreloc: 0
flags: 0x00000000
reserved1: 0x00000000
reserved2: 0x00000000
reserved3: 0x00000000
- sectname: __debug_abbrev
segname: __DWARF
addr: 0x000000010000312C
size: 76
offset: 0x0000212C
align: 0
reloff: 0x00000000
nreloc: 0
flags: 0x00000000
reserved1: 0x00000000
reserved2: 0x00000000
reserved3: 0x00000000
- sectname: __debug_str
segname: __DWARF
addr: 0x0000000100003178
size: 142
offset: 0x00002178
align: 0
reloff: 0x00000000
nreloc: 0
flags: 0x00000000
reserved1: 0x00000000
reserved2: 0x00000000
reserved3: 0x00000000
- sectname: __apple_names
segname: __DWARF
addr: 0x0000000100003206
size: 60
offset: 0x00002206
align: 0
reloff: 0x00000000
nreloc: 0
flags: 0x00000000
reserved1: 0x00000000
reserved2: 0x00000000
reserved3: 0x00000000
- sectname: __apple_namespac
segname: __DWARF
addr: 0x0000000100003242
size: 36
offset: 0x00002242
align: 0
reloff: 0x00000000
nreloc: 0
flags: 0x00000000
reserved1: 0x00000000
reserved2: 0x00000000
reserved3: 0x00000000
- sectname: __apple_types
segname: __DWARF
addr: 0x0000000100003266
size: 114
offset: 0x00002266
align: 0
reloff: 0x00000000
nreloc: 0
flags: 0x00000000
reserved1: 0x00000000
reserved2: 0x00000000
reserved3: 0x00000000
- sectname: __apple_objc
segname: __DWARF
addr: 0x00000001000032D8
size: 36
offset: 0x000022D8
align: 0 align: 0
reloff: 0x00000000 reloff: 0x00000000
nreloc: 0 nreloc: 0
flags: 0x00000000 flags: 0x00000000
reserved1: 0x00000000 reserved1: 0x00000000
reserved2: 0x00000000 reserved2: 0x00000000
reserved3: 0x00000000 reserved3: 0x00000000
LinkEditData:
NameList:
- n_strx: 2
n_type: 0x0F
n_sect: 1
n_desc: 16
n_value: 4294967296
- n_strx: 22
n_type: 0x0F
n_sect: 1
n_desc: 0
n_value: 4294971216
StringTable:
- ''
- ''
- __mh_execute_header
- _main
DWARF: DWARF:
debug_str:
- ''
- 'clang version 4.0.0 (trunk 288923) (llvm/trunk 288991)'
- hello_world.c
- /Users/cbieneman/dev/open-source/llvm-build-rel
- main
- argc
- argv
- int
- char
debug_pubnames: debug_pubnames:
Length: 23 Length: 23
Version: 2 Version: 2
UnitOffset: 0 UnitOffset: 0
UnitSize: 121 UnitSize: 121
Entries: Entries:
- DieOffset: 0x0000002A - DieOffset: 0x0000002A
Name: main Name: main
debug_pubtypes: debug_pubtypes:
Length: 31 Length: 31
Version: 2 Version: 2
UnitOffset: 0 UnitOffset: 0
UnitSize: 121 UnitSize: 121
Entries: Entries:
- DieOffset: 0x00000060 - DieOffset: 0x00000060
Name: int Name: int
- DieOffset: 0x00000071 - DieOffset: 0x00000071
Name: char Name: char
...
# CHECK: DWARF: # CHECK: DWARF:
# CHECK: debug_pubnames: # CHECK: debug_pubnames:
# CHECK-NEXT: Length: 0x0000000000000017 # CHECK-NEXT: Length: 0x0000000000000017
# CHECK-NEXT: Version: 2 # CHECK-NEXT: Version: 2
# CHECK-NEXT: UnitOffset: 0 # CHECK-NEXT: UnitOffset: 0
# CHECK-NEXT: UnitSize: 121 # CHECK-NEXT: UnitSize: 121
# CHECK-NEXT: Entries: # CHECK-NEXT: Entries:
▲ Show 20 Lines • Show All 155 Lines • Show Last 20 Lines