[SYCL]Fix bug: objdump find symbol error on adrp instruction when imm < 0 in arm64

[JuunChen]

Summary

Problem

!image

I used the same llvm-objdump -S -m --section=<section name> <macho-file> command for two different macho files to see the disassembly code.
But the annotation for the assembly instruction can't show for the second file, as shown on the right.

Here is the two files which you can test:
the two macho files.zip

Reason

I found this to be a bug if the adrp's imm < 0, at the followed lines:

adrp_imm = ((info->adrp_inst & 0x00ffffe0) >> 3) | ((info->adrp_inst >> 29) & 0x3);
if (info->adrp_inst & 0x0200000)
     adrp_imm |= 0xfffffffffc000000LL;

The line adrp_imm = ((info->adrp_inst & 0x00ffffe0) >> 3) | ((info->adrp_inst >> 29) & 0x3) find the adrp_imm in adrp_inst, it's right.
And the next two lines are intended to:

1. Determine if adrp_imm is a negative number
2. if the adrp_imm is negative , adrp_imms's 64-bit complement is calculated

However, as shown in the picture:
!image
adrp_imm is encoded as [23:5][31:29].

If you want to determine if adrp_imm is a negative number, you should determine the 23rd bit of adrp_inst, or the 20th bit of adrp_imm.
It will not be info->adrp_inst & 0x0200000. The 0x0200000 is 0b00000000001000000000000000000000，the code is to determine the 21st of adrp_inst，so it doesn't make any sense.
This code adrp_imm |= 0xfffffffffc000000LL is also wrong, it caculated the wrong bits.

Fix

Use the follow code to fix:

if (adrp_imm & (1 << (21 - 1)))
       adrp_imm |= ~((1LL << 21) - 1);

validation

After the correction, I got the result I wanted.

llvm/tools/llvm-objdump/MachODump.cpp

 //===-- MachODump.cpp - Object file dumping utility for llvm --------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
// passed in ReferenceValue.
              ReferencePC - 4 == info->adrp_addr &&
              (info->adrp_inst & 0x9f000000) == 0x90000000 &&
              (info->adrp_inst & 0x1f) == ((ReferenceValue >> 5) & 0x1f)) {
     uint32_t addxri_inst;
     uint64_t adrp_imm, addxri_imm;
 
     adrp_imm =
         ((info->adrp_inst & 0x00ffffe0) >> 3) | ((info->adrp_inst >> 29) & 0x3);
-    if (info->adrp_inst & 0x0200000)
-      adrp_imm |= 0xfffffffffc000000LL;
+    if (adrp_imm & (1 << (21 - 1)))
+      adrp_imm |= ~((1LL << 21) - 1);
 
     addxri_inst = ReferenceValue;
     addxri_imm = (addxri_inst >> 10) & 0xfff;
     if (((addxri_inst >> 22) & 0x3) == 1)
       addxri_imm <<= 12;
 
     ReferenceValue = (info->adrp_addr & 0xfffffffffffff000LL) +
                      (adrp_imm << 12) + addxri_imm;
// instruction is passed in ReferenceValue.
              ReferencePC - 4 == info->adrp_addr &&
              (info->adrp_inst & 0x9f000000) == 0x90000000 &&
              (info->adrp_inst & 0x1f) == ((ReferenceValue >> 5) & 0x1f)) {
     uint32_t ldrxui_inst;
     uint64_t adrp_imm, ldrxui_imm;
 
     adrp_imm =
         ((info->adrp_inst & 0x00ffffe0) >> 3) | ((info->adrp_inst >> 29) & 0x3);
-    if (info->adrp_inst & 0x0200000)
-      adrp_imm |= 0xfffffffffc000000LL;
+    if (adrp_imm & (1 << (21 - 1)))
+      adrp_imm |= ~((1LL << 21) - 1);
 
     ldrxui_inst = ReferenceValue;
     ldrxui_imm = (ldrxui_inst >> 10) & 0xfff;
 
     ReferenceValue = (info->adrp_addr & 0xfffffffffffff000LL) +
                      (adrp_imm << 12) + (ldrxui_imm << 3);
 
     *ReferenceName =