This is an archive of the discontinued LLVM Phabricator instance.

Differential D87690

[libc] Add missing LibcFPTestHelpers library
ClosedPublic

Authored by gchatelet on Sep 15 2020, 5:50 AM.

Download Raw Diff

Details

Reviewers

Commits

rG00d6e7116c20: [libc] Add missing LibcFPTestHelpers library

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

gchatelet created this revision.Sep 15 2020, 5:50 AM

Herald added a project: Restricted Project. · View Herald TranscriptSep 15 2020, 5:50 AM

Herald added subscribers: libc-commits, ecnelises, tschuett, mgorny. · View Herald Transcript

gchatelet requested review of this revision.Sep 15 2020, 5:50 AM

Harbormaster completed remote builds in B71725: Diff 291880.Sep 15 2020, 6:19 AM

How did you catch these? With dynamic linking enabled?

This revision is now accepted and ready to land.Sep 15 2020, 7:00 AM

In D87690#2274070, @sivachandra wrote:

How did you catch these? With dynamic linking enabled?

Yes exactly

This revision was landed with ongoing or failed builds.Sep 15 2020, 7:25 AM

Closed by commit rG00d6e7116c20: [libc] Add missing LibcFPTestHelpers library (authored by gchatelet). · Explain Why

This revision was automatically updated to reflect the committed changes.

gchatelet added a commit: rG00d6e7116c20: [libc] Add missing LibcFPTestHelpers library.

Revision Contents

Path

Size

libc/

utils/

MPFRWrapper/

2 lines

Diff 291914

libc/utils/MPFRWrapper/CMakeLists.txt

	try_compile(			try_compile(
	LIBC_TESTS_CAN_USE_MPFR			LIBC_TESTS_CAN_USE_MPFR
	${CMAKE_CURRENT_BINARY_DIR}			${CMAKE_CURRENT_BINARY_DIR}
	SOURCES			SOURCES
	${CMAKE_CURRENT_SOURCE_DIR}/check_mpfr.cpp			${CMAKE_CURRENT_SOURCE_DIR}/check_mpfr.cpp
	LINK_LIBRARIES			LINK_LIBRARIES
	-lmpfr -lgmp			-lmpfr -lgmp
	)			)

	if(LIBC_TESTS_CAN_USE_MPFR)			if(LIBC_TESTS_CAN_USE_MPFR)
	add_library(libcMPFRWrapper			add_library(libcMPFRWrapper
	MPFRUtils.cpp			MPFRUtils.cpp
	MPFRUtils.h			MPFRUtils.h
	)			)
	add_dependencies(libcMPFRWrapper libc.utils.CPP.standalone_cpp libc.utils.FPUtil.fputil LibcUnitTest LLVMSupport)			add_dependencies(libcMPFRWrapper libc.utils.CPP.standalone_cpp libc.utils.FPUtil.fputil LibcUnitTest LLVMSupport)
	target_link_libraries(libcMPFRWrapper -lmpfr -lgmp LibcUnitTest LLVMSupport)			target_link_libraries(libcMPFRWrapper -lmpfr -lgmp LibcFPTestHelpers LibcUnitTest LLVMSupport)
	else()			else()
	message(WARNING "Math tests using MPFR will be skipped.")			message(WARNING "Math tests using MPFR will be skipped.")
	endif()			endif()