This is an archive of the discontinued LLVM Phabricator instance.

Differential D87687

[libc] Fix typo in platform_defs.h.inc
ClosedPublic

Authored by gchatelet on Sep 15 2020, 5:05 AM.

Details

Reviewers
sivachandra
Commits
rG85763e0758fb: [libc] Fix typo in platform_defs.h.inc

Diff Detail

Unit TestsFailed

TimeTest
500 mswindows > LLVM.DebugInfo::debuglineinfo-path.ll
130 mswindows > LLVM.DebugInfo::symbolize-build-id.test
50 mswindows > LLVM.DebugInfo::symbolize-gnu-debuglink.test
130 mswindows > LLVM.DebugInfo::symbolize.test
140 mswindows > LLVM.DebugInfo/X86::2011-09-26-GlobalVarContext.ll
View Full Test Results (10 Failed)

Event Timeline

gchatelet created this revision.Sep 15 2020, 5:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 15 2020, 5:05 AM
Herald added subscribers: libc-commits, ecnelises, tschuett, mgorny. · View Herald Transcript
gchatelet requested review of this revision.Sep 15 2020, 5:05 AM
Harbormaster completed remote builds in B71719: Diff 291867.Sep 15 2020, 5:44 AM
sivachandra accepted this revision.Sep 15 2020, 7:01 AM
This revision is now accepted and ready to land.Sep 15 2020, 7:01 AM
sivachandra added a comment.Sep 15 2020, 7:06 AM

BTW, you can submit all of these as obvious :)

gchatelet added a comment.Sep 15 2020, 7:24 AM
In D87687#2274087, @sivachandra wrote:

BTW, you can submit all of these as obvious :)

Sounds good !

This revision was landed with ongoing or failed builds.Sep 15 2020, 7:25 AM
Closed by commit rG85763e0758fb: [libc] Fix typo in platform_defs.h.inc (authored by gchatelet). · Explain Why
This revision was automatically updated to reflect the committed changes.
gchatelet added a commit: rG85763e0758fb: [libc] Fix typo in platform_defs.h.inc.

Revision Contents

PathSize
libc/
config/
linux/
platform_defs.h.inc
platfrom_defs.h.inc
13 lines
src/
__support/
4 lines

Diff 291867

libc/config/linux/platform_defs.h.inc

  • This file was moved from libc/config/linux/platfrom_defs.h.inc.
//===----- Definition of platform specific macros for ELF paltforms -------===// //===----- Definition of platform specific macros for ELF paltforms -------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
%%begin() %%begin()
#define ENTRYPOINT_SECTION_ATTRIBUTE(name) \ #define ENTRYPOINT_SECTION_ATTRIBUTE(name) \
__attribute__((section(".llvm.libc.entrypoint."#name))) __attribute__((section(".llvm.libc.entrypoint."#name)))
#define LLVM_LIBC_ENTRYPOINT(name) ENTRYPOINT_SECTION_ATTRIBUTE(name) name #define LLVM_LIBC_ENTRYPOINT(name) ENTRYPOINT_SECTION_ATTRIBUTE(name) name

libc/config/linux/platfrom_defs.h.inc

  • This file was moved to libc/config/linux/platform_defs.h.inc.

libc/src/__support/CMakeLists.txt

add_gen_header( add_gen_header(
common common
DEF_FILE common.h.def DEF_FILE common.h.def
PARAMS PARAMS
platform_defs=../../config/${LIBC_TARGET_OS}/platfrom_defs.h.inc platform_defs=../../config/${LIBC_TARGET_OS}/platform_defs.h.inc
GEN_HDR common.h GEN_HDR common.h
DATA_FILES DATA_FILES
../../config/${LIBC_TARGET_OS}/platfrom_defs.h.inc ../../config/${LIBC_TARGET_OS}/platform_defs.h.inc
) )