This is an archive of the discontinued LLVM Phabricator instance.

Differential D87659

clang-format
AbandonedPublic

Authored by dschuff on Sep 14 2020, 6:12 PM.

Details

Reviewers
sbc100

Diff Detail

Event Timeline

dschuff created this revision.Sep 14 2020, 6:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 14 2020, 6:12 PM
Herald added subscribers: llvm-commits, hiraditya, sbc100. · View Herald Transcript
dschuff requested review of this revision.Sep 14 2020, 6:12 PM
Herald added a subscriber: aheejin. · View Herald TranscriptSep 14 2020, 6:12 PM
Harbormaster completed remote builds in B71662: Diff 291749.Sep 14 2020, 6:12 PM
sbc100 accepted this revision.Sep 14 2020, 6:17 PM
This revision is now accepted and ready to land.Sep 14 2020, 6:17 PM
dschuff abandoned this revision.Sep 15 2020, 8:33 AM

sorry, Arcanist snafu. This should have been included in a different change

Revision Contents

PathSize
llvm/
lib/
MC/
13 lines

Diff 291749

llvm/lib/MC/WasmObjectWriter.cpp

Show First 20 Lines • Show All 315 Lines • ▼ Show 20 Linesprivate:
void writeHeader(const MCAssembler &Asm); void writeHeader(const MCAssembler &Asm);
void recordRelocation(MCAssembler &Asm, const MCAsmLayout &Layout, void recordRelocation(MCAssembler &Asm, const MCAsmLayout &Layout,
const MCFragment *Fragment, const MCFixup &Fixup, const MCFragment *Fragment, const MCFixup &Fixup,
MCValue Target, uint64_t &FixedValue) override; MCValue Target, uint64_t &FixedValue) override;
void executePostLayoutBinding(MCAssembler &Asm, void executePostLayoutBinding(MCAssembler &Asm,
const MCAsmLayout &Layout) override; const MCAsmLayout &Layout) override;
void prepareImports(SmallVectorImpl<wasm::WasmImport>& Imports, void prepareImports(SmallVectorImpl<wasm::WasmImport> &Imports,
MCAssembler &Asm, MCAssembler &Asm, const MCAsmLayout &Layout);
const MCAsmLayout &Layout);
uint64_t writeObject(MCAssembler &Asm, const MCAsmLayout &Layout) override; uint64_t writeObject(MCAssembler &Asm, const MCAsmLayout &Layout) override;
uint64_t writeOneObject(MCAssembler &Asm, const MCAsmLayout &Layout, uint64_t writeOneObject(MCAssembler &Asm, const MCAsmLayout &Layout,
DwoMode Mode); DwoMode Mode);
void writeString(const StringRef Str) { void writeString(const StringRef Str) {
encodeULEB128(Str.size(), W->OS); encodeULEB128(Str.size(), W->OS);
W->OS << Str; W->OS << Str;
▲ Show 20 Lines • Show All 623 Lines • ▼ Show 20 Linesuint32_t WasmObjectWriter::writeDataSection(const MCAsmLayout &Layout) {
encodeULEB128(DataSegments.size(), W->OS); // count encodeULEB128(DataSegments.size(), W->OS); // count
for (const WasmDataSegment &Segment : DataSegments) { for (const WasmDataSegment &Segment : DataSegments) {
encodeULEB128(Segment.InitFlags, W->OS); // flags encodeULEB128(Segment.InitFlags, W->OS); // flags
if (Segment.InitFlags & wasm::WASM_SEGMENT_HAS_MEMINDEX) if (Segment.InitFlags & wasm::WASM_SEGMENT_HAS_MEMINDEX)
encodeULEB128(0, W->OS); // memory index encodeULEB128(0, W->OS); // memory index
if ((Segment.InitFlags & wasm::WASM_SEGMENT_IS_PASSIVE) == 0) { if ((Segment.InitFlags & wasm::WASM_SEGMENT_IS_PASSIVE) == 0) {
W->OS << char(Segment.Offset > INT32_MAX ? wasm::WASM_OPCODE_I64_CONST W->OS << char(Segment.Offset > INT32_MAX ? wasm::WASM_OPCODE_I64_CONST
: wasm::WASM_OPCODE_I32_CONST); : wasm::WASM_OPCODE_I32_CONST);
encodeSLEB128(Segment.Offset, W->OS); // offset encodeSLEB128(Segment.Offset, W->OS); // offset
W->OS << char(wasm::WASM_OPCODE_END); W->OS << char(wasm::WASM_OPCODE_END);
} }
encodeULEB128(Segment.Data.size(), W->OS); // size encodeULEB128(Segment.Data.size(), W->OS); // size
Segment.Section->setSectionOffset(W->OS.tell() - Section.ContentsOffset); Segment.Section->setSectionOffset(W->OS.tell() - Section.ContentsOffset);
W->OS << Segment.Data; // data W->OS << Segment.Data; // data
} }
▲ Show 20 Lines • Show All 218 Lines • ▼ Show 20 Linesstatic bool isInSymtab(const MCSymbolWasm &Sym) {
if (Sym.isTemporary()) if (Sym.isTemporary())
return false; return false;
if (Sym.isSection()) if (Sym.isSection())
return false; return false;
return true; return true;
} }
void WasmObjectWriter::prepareImports(SmallVectorImpl<wasm::WasmImport>& Imports, void WasmObjectWriter::prepareImports(
MCAssembler &Asm, SmallVectorImpl<wasm::WasmImport> &Imports, MCAssembler &Asm,
const MCAsmLayout &Layout) { const MCAsmLayout &Layout) {
// For now, always emit the memory import, since loads and stores are not // For now, always emit the memory import, since loads and stores are not
// valid without it. In the future, we could perhaps be more clever and omit // valid without it. In the future, we could perhaps be more clever and omit
// it if there are no loads or stores. // it if there are no loads or stores.
wasm::WasmImport MemImport; wasm::WasmImport MemImport;
MemImport.Module = "env"; MemImport.Module = "env";
MemImport.Field = "__linear_memory"; MemImport.Field = "__linear_memory";
MemImport.Kind = wasm::WASM_EXTERNAL_MEMORY; MemImport.Kind = wasm::WASM_EXTERNAL_MEMORY;
MemImport.Memory.Flags = is64Bit() ? wasm::WASM_LIMITS_FLAG_IS_64 MemImport.Memory.Flags = is64Bit() ? wasm::WASM_LIMITS_FLAG_IS_64
▲ Show 20 Lines • Show All 584 Lines • Show Last 20 Lines