Page MenuHomePhabricator

[Support] Make building with snmalloc work
ClosedPublic

Authored by hans on Thu, Sep 10, 10:35 AM.

Details

Diff Detail

Event Timeline

hans created this revision.Thu, Sep 10, 10:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Sep 10, 10:35 AM

You can't blindly specify "-mcx16" without checking the target.

Please take a look. See https://reviews.llvm.org/D71786#2265789 for details.

Tested, works for me, thanks!

llvm/lib/Support/CMakeLists.txt
256

You can't blindly specify "-mcx16" without checking the target.

LLVM_INTEGRATED_CRT_ALLOC is already Windows-only, even though Unix could work too (at least all three allocators support Unix). What about if (${CMAKE_SYSTEM_PROCESSOR} MATCHES "x86_64" (which also accounts for ARM Windows)

efriedma added inline comments.Thu, Sep 10, 4:39 PM
llvm/lib/Support/CMakeLists.txt
256

Sure.

hans updated this revision to Diff 291546.Mon, Sep 14, 5:17 AM

Added target condition.

Please take another look.

aganea accepted this revision.Mon, Sep 14, 5:19 AM

LGTM.

This revision is now accepted and ready to land.Mon, Sep 14, 5:19 AM
This revision was automatically updated to reflect the committed changes.