Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
I have realized this is the wrong change
The actual error is in Format.h
clang/docs/ClangFormatStyleOption.rst is generated using the clang/docs/tools/dump_format_style.py if we commit this change in the rst will get reintroduced when that is run
If you are still interested please change Format.h
/// Break parameters list into lines when there is nested block
/// parameters in a fuction call.
/// \code
/// false:
/// - (void)_aMethod
/// {
/// [self.test1 t:self w:self callback:^(typeof(self) self, NSNumber
/// *u, NSNumber *v) {
/// u = c;
/// }]
/// }Ok almost...
so you change the Format.h, then run the docs/tools/clang_format_style.py and attach both the rst and the .h to the review
| clang/docs/ClangFormatStyleOptions.rst | ||
|---|---|---|
| 778 | So this is an example of where someone has changed the .rst and not the Format.h! @arichardson I recommend keeping Format.h and rst in lock step. | |
| clang/docs/ClangFormatStyleOptions.rst | ||
|---|---|---|
| 778 | Ah I was not aware of that script, I just did both manually but must have adjusted one later. Sorry! | |
So this is an example of where someone has changed the .rst and not the Format.h! @arichardson
I recommend keeping Format.h and rst in lock step.