Page MenuHomePhabricator

YangZhihui (YangZhihui)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2020, 10:45 PM (9 w, 7 h)

Recent Activity

Wed, Sep 23

YangZhihui added a comment to D88074: Add parentheses to eliminate warning.

LGTM - thanks. But please do use clang-format to make the bots happy.

Wed, Sep 23, 6:29 PM · Restricted Project

Tue, Sep 22

YangZhihui added a comment to D88003: Fix typos in ASTMatchers.h.

LGTM!

Tue, Sep 22, 7:23 PM · Restricted Project
YangZhihui updated the diff for D88074: Add parentheses to eliminate warning.
Tue, Sep 22, 7:21 PM · Restricted Project

Sep 22 2020

YangZhihui requested review of D88074: Add parentheses to eliminate warning.
Sep 22 2020, 1:01 AM · Restricted Project

Sep 21 2020

YangZhihui updated the diff for D88003: Fix typos in ASTMatchers.h.
Sep 21 2020, 8:44 PM · Restricted Project
YangZhihui requested review of D88003: Fix typos in ASTMatchers.h.
Sep 21 2020, 1:03 AM · Restricted Project

Sep 16 2020

YangZhihui added a comment to D87672: [doc] Fix typos.

Thank you very much for fixing these problems!

Thanks,
may be you can help commit it : )
by the way, why the unittest failed?
This change should not fail the unit test.

Sep 16 2020, 2:50 AM · Restricted Project

Sep 15 2020

YangZhihui updated the diff for D87352: Fix typo.
Sep 15 2020, 7:04 PM · Restricted Project
YangZhihui added a comment to D87352: Fix typo.

I have realized this is the wrong change

The actual error is in Format.h

clang/docs/ClangFormatStyleOption.rst is generated using the clang/docs/tools/dump_format_style.py if we commit this change in the rst will get reintroduced when that is run

If you are still interested please change Format.h

/// Break parameters list into lines when there is nested block
 /// parameters in a fuction call.
 /// \code
 ///   false:
 ///    - (void)_aMethod
 ///    {
 ///        [self.test1 t:self w:self callback:^(typeof(self) self, NSNumber
 ///        *u, NSNumber *v) {
 ///            u = c;
 ///        }]
 ///    }
Sep 15 2020, 1:23 AM · Restricted Project
YangZhihui updated the diff for D87352: Fix typo.
Sep 15 2020, 1:21 AM · Restricted Project
YangZhihui requested review of D87672: [doc] Fix typos.
Sep 15 2020, 12:46 AM · Restricted Project
YangZhihui added a comment to D87352: Fix typo.

LGTM, thank you for doing this..

Sep 15 2020, 12:40 AM · Restricted Project

Sep 10 2020

YangZhihui added a comment to D87438: Fix typo in dsymutil.rst.

If there is no problem,
please help me commit it.
Thanks :-)

Sep 10 2020, 12:35 AM · Restricted Project
YangZhihui requested review of D87438: Fix typo in dsymutil.rst.
Sep 10 2020, 12:31 AM · Restricted Project

Sep 9 2020

YangZhihui added a comment to D87356: [docs] Fix typos.

LGTM

Sep 9 2020, 10:45 PM · Restricted Project
YangZhihui requested review of D87356: [docs] Fix typos.
Sep 9 2020, 2:21 AM · Restricted Project
YangZhihui added a comment to D87352: Fix typo.

I don't have commit access.
Please help me commit it.
Thanks : )

Sep 9 2020, 1:47 AM · Restricted Project
YangZhihui requested review of D87352: Fix typo.
Sep 9 2020, 1:46 AM · Restricted Project

Sep 3 2020

YangZhihui added a comment to D87077: Fix typos in doc LangRef.rst.

I don't have commit access.
Maybe someone can help me commit it.
Thanks : )

Sep 3 2020, 1:57 AM · Restricted Project
YangZhihui requested review of D87077: Fix typos in doc LangRef.rst.
Sep 3 2020, 1:55 AM · Restricted Project

Aug 25 2020

YangZhihui added a comment to D86427: Fix some spelling errors.

how can I add the Author property in the patch
Thanks

Is your email yangzh.fnst@cn.fujitsu.com associated with a github account? If it is, this is all I need.

Aug 25 2020, 7:38 PM · Restricted Project
YangZhihui added a comment to D86427: Fix some spelling errors.

how can I add the Author property in the patch
Thanks

Aug 25 2020, 2:52 AM · Restricted Project
YangZhihui added a comment to D86427: Fix some spelling errors.

Thanks,
Full Name: Yang Zhihui
Email: yangzh.fnst@cn.fujitsu.com

Aug 25 2020, 2:47 AM · Restricted Project
YangZhihui added a comment to D86427: Fix some spelling errors.

Thanks, but I don't have commit access

Aug 25 2020, 2:17 AM · Restricted Project
YangZhihui added a comment to D86504: Fix word errors .

Fullname: Yang Zhihui
email: yangzh.fnst@cn.fujitsu.com

Aug 25 2020, 1:49 AM · Restricted Project
YangZhihui added a comment to D86504: Fix word errors .

Thanks , but I don't have commit access

Aug 25 2020, 1:38 AM · Restricted Project

Aug 24 2020

YangZhihui requested review of D86504: Fix word errors .
Aug 24 2020, 7:36 PM · Restricted Project

Aug 23 2020

YangZhihui requested review of D86427: Fix some spelling errors.
Aug 23 2020, 8:14 PM · Restricted Project
YangZhihui abandoned D86329: Fix spelling errors in the doc.
Aug 23 2020, 7:55 PM · Restricted Project

Aug 20 2020

YangZhihui added a comment to D86265: Fix spelling errors in the doc.

Hi, I think this change looks reasonable. Why it was abandoned?

Aug 20 2020, 10:13 PM · Restricted Project
YangZhihui requested review of D86329: Fix spelling errors in the doc.
Aug 20 2020, 8:14 PM · Restricted Project
YangZhihui abandoned D86265: Fix spelling errors in the doc.
Aug 20 2020, 7:49 PM · Restricted Project
YangZhihui added a reviewer for D86265: Fix spelling errors in the doc: Restricted Project.
Aug 20 2020, 7:46 PM · Restricted Project
YangZhihui abandoned D86264: Fix spelling errors in the doc.
Aug 20 2020, 7:43 PM

Aug 19 2020

YangZhihui requested review of D86265: Fix spelling errors in the doc.
Aug 19 2020, 11:08 PM · Restricted Project
YangZhihui requested review of D86264: Fix spelling errors in the doc.
Aug 19 2020, 10:57 PM