[NFC][ThinLTO] EmbedBitcodeSection doesn't need the Config

[mtrofin]

Summary

Instead, passing in the command line options, initialized to nullptr. In
an upcoming patch, we can then use the parameter to pass actual command
line options.

[tejohnson]

Why not just make this one an NFC change to remove the unused Conf parameter. Then pass in CmdLineOpts in the patch where its use is added?

[mtrofin]

feedback

[mtrofin]

In D87336#2262263, @tejohnson wrote:

Why not just make this one an NFC change to remove the unused Conf parameter. Then pass in CmdLineOpts in the patch where its use is added?

Oh, yes! Thanks - done.

[tejohnson]

llvm/lib/LTO/LTOBackend.cpp

362

Why this change? Now Buf is unused.

[mtrofin]

removed unrelated change

[mtrofin]

llvm/lib/LTO/LTOBackend.cpp

362

Oh - fixed. I was going to do that next and forgot to undo the change. Turns out, llvm::EmbedBitcodeInModule handles that case - i.e. if you pass an invalid memory buffer, it will extract it from the provided Module. Separate change, in any case.

[tejohnson]

LGTM

llvm/lib/LTO/LTOBackend.cpp

else
     runOldPMPasses(Conf, Mod, TM, IsThinLTO, ExportSummary, ImportSummary);
   return !Conf.PostOptModuleHook || Conf.PostOptModuleHook(Task, Mod);
 }
 
 static cl::opt<bool> EmbedBitcode(
     "lto-embed-bitcode", cl::init(false),
     cl::desc("Embed LLVM bitcode in object files produced by LTO"));
 
-static void EmitBitcodeSection(Module &M, const Config &Conf) {
+static void EmitBitcodeSection(Module &M) {
   if (!EmbedBitcode)
     return;
   SmallVector<char, 0> Buffer;
   raw_svector_ostream OS(Buffer);
   WriteBitcodeToFile(M, OS);
 
   std::unique_ptr<MemoryBuffer> Buf(
       new SmallVectorMemoryBuffer(std::move(Buffer)));
   llvm::EmbedBitcodeInModule(M, Buf->getMemBufferRef(), /*EmbedBitcode*/ true,
                              /*EmbedMarker*/ false, /*CmdArgs*/ nullptr);
 }
 
 void codegen(const Config &Conf, TargetMachine *TM, AddStreamFn AddStream,
              unsigned Task, Module &Mod,
              const ModuleSummaryIndex &CombinedIndex) {
   if (Conf.PreCodeGenModuleHook && !Conf.PreCodeGenModuleHook(Task, Mod))
     return;
 
-  EmitBitcodeSection(Mod, Conf);
+  EmitBitcodeSection(Mod);
 
   std::unique_ptr<ToolOutputFile> DwoOut;
   SmallString<1024> DwoFile(Conf.SplitDwarfOutput);
   if (!Conf.DwoDir.empty()) {
     std::error_code EC;
     if (auto EC = llvm::sys::fs::create_directories(Conf.DwoDir))
       report_fatal_error("Failed to create directory " + Conf.DwoDir + ": " +
                          EC.message());