Page MenuHomePhabricator

[debugserver] Extract function for default launch flavor
ClosedPublic

Authored by kastiglione on Sep 8 2020, 1:50 PM.

Details

Summary

Extract a function for turning eLaunchFlavorDefault into a concreate eLaunchFlavor value.

This new function encapsulates the few compile time variables involved, and also prevents clang unused code diagnostics.

Diff Detail

Event Timeline

kastiglione created this revision.Sep 8 2020, 1:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 8 2020, 1:50 PM
kastiglione requested review of this revision.Sep 8 2020, 1:50 PM

clang-format

teemperor accepted this revision.Sep 9 2020, 12:10 AM

LGTM, thanks for the cleanup! (And also having the second list of comments no longer always stating 'SpringBoard' is even better).

This revision is now accepted and ready to land.Sep 9 2020, 12:10 AM

@teemperor I'm not sure what these build errors mean, for example https://reviews.llvm.org/B70998. Also there's the linux build failure, but that's not relevant for debugserver, right?

@teemperor I'm not sure what these build errors mean, for example https://reviews.llvm.org/B70998. Also there's the linux build failure, but that's not relevant for debugserver, right?

You can usually ignore premerge checks that aren't clang-format complaining. And for linux buildbot failures I think that's also fine as they don't build debug server from what I know.

This revision was landed with ongoing or failed builds.Sep 9 2020, 11:35 AM
This revision was automatically updated to reflect the committed changes.