[NFC][compiler-rt] Refine .clang-tidy checks

[vitalybuka]

new lines

[vitalybuka]

misc-unused-parameters

[MaskRay]

Thanks! I think one reason that people don't use InheritParentConfig is that it is too new (cb1ee34e9d32fce84613827693a8ed3aff1d36cf 2020-04). For pre-merge checkers' purposes, we can use it I think... Is InheritParentConfig ignored for older clang-tidy?

[vitalybuka]

In D87182#2257775, @MaskRay wrote:

Thanks! I think one reason that people don't use InheritParentConfig is that it is too new (cb1ee34e9d32fce84613827693a8ed3aff1d36cf 2020-04). For pre-merge checkers' purposes, we can use it I think... Is InheritParentConfig ignored for older clang-tidy?

I didn't know that this is so new.
It reports error and turn on set of default checks which cause a lot of warning on compiler-rt.
If we can't use, I'd rather not duplicate and use single root config like it's now with your patch.
I'd try to merge it. WDYT?

[MaskRay]

In D87182#2257832, @vitalybuka wrote:

In D87182#2257775, @MaskRay wrote:

Thanks! I think one reason that people don't use InheritParentConfig is that it is too new (cb1ee34e9d32fce84613827693a8ed3aff1d36cf 2020-04). For pre-merge checkers' purposes, we can use it I think... Is InheritParentConfig ignored for older clang-tidy?

I didn't know that this is so new.
It reports error and turn on set of default checks which cause a lot of warning on compiler-rt.
If we can't use, I'd rather not duplicate and use single root config like it's now with your patch.
I'd try to merge it. WDYT?

A readability-identifier-naming disabling root .clang-tidy sounds good!

[vitalybuka]

In D87182#2257833, @MaskRay wrote:

In D87182#2257832, @vitalybuka wrote:

In D87182#2257775, @MaskRay wrote:

Thanks! I think one reason that people don't use InheritParentConfig is that it is too new (cb1ee34e9d32fce84613827693a8ed3aff1d36cf 2020-04). For pre-merge checkers' purposes, we can use it I think... Is InheritParentConfig ignored for older clang-tidy?

I didn't know that this is so new.
It reports error and turn on set of default checks which cause a lot of warning on compiler-rt.
If we can't use, I'd rather not duplicate and use single root config like it's now with your patch.
I'd try to merge it. WDYT?

A readability-identifier-naming disabling root .clang-tidy sounds good!

OK. Abandoning.

[vitalybuka]

remove InheritParentConfig

[vitalybuka]

I'll still submit this subset.

compiler-rt/.clang-tidy

-# Checks enabled in the top-level .clang-tidy minus readability-identifier-naming
-Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes'
+# Checks enabled in the top-level .clang-tidy minus readability-identifier-naming and llvm-header-guard.
+Checks: '-*,clang-diagnostic-*,llvm-*,-llvm-header-guard,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes'

compiler-rt/lib/sanitizer_common/.clang-tidy

-Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,readability-identifier-naming'
-CheckOptions:
-  - key:             readability-identifier-naming.ClassCase
-    value:           CamelCase
-  - key:             readability-identifier-naming.EnumCase
-    value:           CamelCase
-  - key:             readability-identifier-naming.FunctionCase
-    value:           CamelCase
-  - key:             readability-identifier-naming.UnionCase
-    value:           CamelCase
-  - key:             readability-identifier-naming.GlobalConstantCase
-    value:           CamelCase
-  - key:             readability-identifier-naming.GlobalConstantPrefix
-    value:           "k"
-  - key:             readability-identifier-naming.VariableCase
-    value:           lower_case

compiler-rt/test/.clang-tidy

+Checks: '-*'