This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][MC] Corrected parser to avoid excessive error messages
ClosedPublic

Authored by dp on Sep 1 2020, 7:34 AM.

Details

Summary

Corrected parser to avoid generation of multiple messages for a single error.

Summary of changes:

  • Changed parser to eliminate generation of excessive error messages;
  • Corrected lit tests to match all expected error messages;
  • Corrected lit tests to guard against unwanted extra messages (added option "--implicit-check-not=error:");
  • Added missing checks and fixed some typos in tests.

Note that changes in gfx8_asm_all.s, gfx9_asm_all.s and gfx10_asm_all.s are not shown because the files are too large.

See bug 46907

Diff Detail

Event Timeline

dp created this revision.Sep 1 2020, 7:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 1 2020, 7:34 AM
dp requested review of this revision.Sep 1 2020, 7:34 AM
This revision is now accepted and ready to land.Sep 1 2020, 11:05 AM