This is an archive of the discontinued LLVM Phabricator instance.

[ORC][NFC] Fix gcc warning by remove the extra semicolon
ClosedPublic

Authored by nullptr.cpp on Aug 30 2020, 8:48 PM.

Details

Reviewers
lhames
Summary

Full diagnostic:

llvm-project/llvm/lib/ExecutionEngine/Orc/Core.cpp:1921:2: warning: extra ‘;’ [-Wpedantic]
 1921 | };
      |  ^

This semicolon is at the end of function definition:

1887 std::vector<std::shared_ptr<JITDylib>>
1888 JITDylib::getDFSLinkOrder(ArrayRef<std::shared_ptr<JITDylib>> JDs) {
       ...
1921 };

No need to add a semicolon here, remove it.

Diff Detail

Event Timeline

nullptr.cpp created this revision.Aug 30 2020, 8:48 PM
nullptr.cpp requested review of this revision.Aug 30 2020, 8:49 PM
lhames accepted this revision.Aug 31 2020, 1:05 PM

LGTM. Thanks for catching that!

This revision is now accepted and ready to land.Aug 31 2020, 1:05 PM

Looks like Sourabh already got this in db464a2753e2b3dee7a1438cd8ccc33795fc9529. Thanks to both of you. :)

lhames closed this revision.Aug 31 2020, 1:06 PM