This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readobj][test] - Remove amdgpu-elf-definitions.test
ClosedPublic

Authored by grimar on Aug 28 2020, 4:07 AM.

Details

Summary

amdgpu-elf-definitions.test is a file that tests
Format, 'OS/ABI' and 'Machine' fields printed for EM_AMDGPU.
It uses a precompiled object.

It is not needed to have it, because:

  1. We already test formats in file-header-format.test + llvm/unittests/Object/ELFObjectFileTest.cpp.
  2. We test 'OS/ABI' in file-header-os-abi.test for all possible values.
  3. We test machine types in file-header-machine-types.test

In addition we have amdgpu-elf-headers.test which tests EM_AMDGPU specific flags. I.e.
it also tests the fact that llvm-readobj/elf are able to dump such objects.

This patch removes the test case and the corresponding binary.

Diff Detail

Event Timeline

grimar created this revision.Aug 28 2020, 4:07 AM
Herald added a project: Restricted Project. · View Herald Transcript
grimar requested review of this revision.Aug 28 2020, 4:07 AM
This revision is now accepted and ready to land.Sep 1 2020, 12:56 AM
This revision was automatically updated to reflect the committed changes.