This is an archive of the discontinued LLVM Phabricator instance.

Differential D86705

Fix OpenMP deduplicateRuntimeCalls return status
ClosedPublic

Authored by serge-sans-paille on Aug 27 2020, 5:40 AM.

Details

Reviewers
jdoerfert
Commits
rG4e29d2566941: Fix OpenMP deduplicateRuntimeCalls return status
Summary

This is a requirement for https://reviews.llvm.org/D86589

Diff Detail

Event Timeline

serge-sans-paille created this revision.Aug 27 2020, 5:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2020, 5:40 AM
Herald added subscribers: llvm-commits, guansong, hiraditya, yaxunl. · View Herald Transcript
serge-sans-paille requested review of this revision.Aug 27 2020, 5:40 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptAug 27 2020, 5:40 AM
Herald added a subscriber: sstefan1. · View Herald Transcript
jdoerfert accepted this revision.Aug 27 2020, 5:45 AM

LGTM, thx!

This revision is now accepted and ready to land.Aug 27 2020, 5:45 AM
Closed by commit rG4e29d2566941: Fix OpenMP deduplicateRuntimeCalls return status (authored by serge-sans-paille). · Explain WhyAug 27 2020, 6:01 AM
This revision was automatically updated to reflect the committed changes.
serge-sans-paille added a commit: rG4e29d2566941: Fix OpenMP deduplicateRuntimeCalls return status.

Revision Contents

PathSize
llvm/
lib/
Transforms/
IPO/
4 lines

Diff 288301

llvm/lib/Transforms/IPO/OpenMPOpt.cpp

Show First 20 Lines • Show All 651 Lines • ▼ Show 20 Lines bool deduplicateRuntimeCalls() {
// Global-tid is handled separately. // Global-tid is handled separately.
SmallSetVector<Value *, 16> GTIdArgs; SmallSetVector<Value *, 16> GTIdArgs;
collectGlobalThreadIdArguments(GTIdArgs); collectGlobalThreadIdArguments(GTIdArgs);
LLVM_DEBUG(dbgs() << TAG << "Found " << GTIdArgs.size() LLVM_DEBUG(dbgs() << TAG << "Found " << GTIdArgs.size()
<< " global thread ID arguments\n"); << " global thread ID arguments\n");
for (Function *F : SCC) { for (Function *F : SCC) {
for (auto DeduplicableRuntimeCallID : DeduplicableRuntimeCallIDs) for (auto DeduplicableRuntimeCallID : DeduplicableRuntimeCallIDs)
deduplicateRuntimeCalls(*F, Changed |= deduplicateRuntimeCalls(
OMPInfoCache.RFIs[DeduplicableRuntimeCallID]); *F, OMPInfoCache.RFIs[DeduplicableRuntimeCallID]);
// __kmpc_global_thread_num is special as we can replace it with an // __kmpc_global_thread_num is special as we can replace it with an
// argument in enough cases to make it worth trying. // argument in enough cases to make it worth trying.
Value *GTIdArg = nullptr; Value *GTIdArg = nullptr;
for (Argument &Arg : F->args()) for (Argument &Arg : F->args())
if (GTIdArgs.count(&Arg)) { if (GTIdArgs.count(&Arg)) {
GTIdArg = &Arg; GTIdArg = &Arg;
break; break;
▲ Show 20 Lines • Show All 960 Lines • Show Last 20 Lines