Page MenuHomePhabricator
Differential D86692

[NFC][ValueTracking] Add OffsetZero into findAllocaForValue
ClosedPublic
Actions

Authored by vitalybuka on Aug 27 2020, 2:28 AM.

Details

Reviewers
eugenis
Commits
rGa6927c862126: [NFC][ValueTracking] Add OffsetZero into findAllocaForValue
Summary

For StackLifetime after finding alloca we need to check that
values ponting to the begining of alloca.

Diff Detail

Unit TestsFailed
View All

TimeTest
20 mslinux > LLVM-Unit.Analysis/_/AnalysisTests::FindAllocaForValueTest/FindAllocaForValueTest.findAllocaForValue/9
Note: Google Test filter = FindAllocaForValueTest/FindAllocaForValueTest.findAllocaForValue/9 [==========] Running 1 test from 1 test case. [----------] Global test environment set-up.
20 mslinux > LLVM-Unit.Analysis/_/AnalysisTests::FindAllocaForValueTest/FindAllocaForValueTest.findAllocaForValueZeroOffset/9
Note: Google Test filter = FindAllocaForValueTest/FindAllocaForValueTest.findAllocaForValueZeroOffset/9 [==========] Running 1 test from 1 test case. [----------] Global test environment set-up.
110 mswindows > LLVM-Unit.Analysis/_/AnalysisTests_exe::FindAllocaForValueTest/FindAllocaForValueTest.findAllocaForValue/9
Note: Google Test filter = FindAllocaForValueTest/FindAllocaForValueTest.findAllocaForValue/9 [==========] Running 1 test from 1 test case.
120 mswindows > LLVM-Unit.Analysis/_/AnalysisTests_exe::FindAllocaForValueTest/FindAllocaForValueTest.findAllocaForValueZeroOffset/9
Note: Google Test filter = FindAllocaForValueTest/FindAllocaForValueTest.findAllocaForValueZeroOffset/9 [==========] Running 1 test from 1 test case.

Event Timeline

vitalybuka created this revision.Aug 27 2020, 2:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2020, 2:28 AM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
vitalybuka requested review of this revision.Aug 27 2020, 2:28 AM
vitalybuka added a child revision: D86672: [StackSafety] Ignore allocas with partial lifetime markers.Aug 27 2020, 2:51 AM
vitalybuka updated this revision to Diff 288257.Aug 27 2020, 3:03 AM

rebase

Harbormaster completed remote builds in B69746: Diff 288243.Aug 27 2020, 3:03 AM
vitalybuka updated this revision to Diff 288261.Aug 27 2020, 3:27 AM

rebase

vitalybuka retitled this revision from [NFC,ValueTracking] Add OffsetZero into findAllocaForValue to [NFC][ValueTracking] Add OffsetZero into findAllocaForValue.Aug 27 2020, 3:29 AM
Harbormaster completed remote builds in B69751: Diff 288257.Aug 27 2020, 3:34 AM
Harbormaster completed remote builds in B69754: Diff 288261.Aug 27 2020, 4:04 AM
eugenis accepted this revision.Aug 27 2020, 1:16 PM

LGTM

llvm/lib/Analysis/ValueTracking.cpp
4371

Please address the lint warning.

This revision is now accepted and ready to land.Aug 27 2020, 1:16 PM
nikic added a subscriber: nikic.Aug 27 2020, 1:20 PM
nikic added inline comments.
llvm/lib/Analysis/ValueTracking.cpp
4375

You can just use GEP->hasAllZeroIndices() here.

vitalybuka updated this revision to Diff 288448.Aug 27 2020, 1:44 PM
vitalybuka marked 2 inline comments as done.

comments

This revision was landed with ongoing or failed builds.Aug 27 2020, 1:46 PM
Closed by commit rGa6927c862126: [NFC][ValueTracking] Add OffsetZero into findAllocaForValue (authored by vitalybuka). · Explain Why
This revision was automatically updated to reflect the committed changes.
vitalybuka added a commit: rGa6927c862126: [NFC][ValueTracking] Add OffsetZero into findAllocaForValue.
Harbormaster completed remote builds in B69836: Diff 288448.Aug 27 2020, 3:19 PM

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
Analysis/
10 lines
lib/
Analysis/
41 lines
unittests/
Analysis/
60 lines

Diff 288243

View Options

llvm/include/llvm/Analysis/ValueTracking.h

Loading...
View Options

llvm/lib/Analysis/ValueTracking.cpp

Loading...
View Options

llvm/unittests/Analysis/ValueTrackingTest.cpp

Loading...